Merge pull request #106 from xinlifoobar/master

Proxy Http Reason Phrase to Avoid Unconscious Incompatibilities.

src/Core/Extensions/Http.cs

@@ -6,6 +6,7 @@
 using System.Threading.Tasks;
 using AspNetCore.Proxy.Builders;
 using Microsoft.AspNetCore.Http;
+using Microsoft.AspNetCore.Http.Features;
 using Microsoft.Extensions.DependencyInjection;
 
 namespace AspNetCore.Proxy
@@ -124,6 +125,13 @@ private static Task WriteProxiedHttpResponseAsync(this HttpContext context, Http
             var response = context.Response;
 
             response.StatusCode = (int)responseMessage.StatusCode;
+
+            var httpResponseFeature = context.Features.Get<IHttpResponseFeature>();
+            if (httpResponseFeature != null)
+            {
+                httpResponseFeature.ReasonPhrase = responseMessage.ReasonPhrase;
+            }
+
             foreach (var header in responseMessage.Headers)
             {
                 response.Headers[header.Key] = header.Value.ToArray();

src/Test/Http/HttpHelpers.cs

@@ -9,6 +9,7 @@
 using Microsoft.Extensions.DependencyInjection;
 using AspNetCore.Proxy.Options;
 using System.Diagnostics.CodeAnalysis;
+using Microsoft.AspNetCore.Http.Features;
 
 [assembly: SuppressMessage("Readability", "RCS1090", Justification = "Not a library, so no need for `ConfigureAwait`.")]
 
@@ -143,6 +144,31 @@ public Task GetWithCustomResponse(int postId)
             return this.HttpProxyAsync($"https://jsonplaceholder.typicode.com/posts/{postId}", options);
         }
 
+        [Route("api/controller/customreasonphase")]
+        public void GetWithCustomReasonPhase(int postId)
+        {
+        }
+
+        [Route("api/controller/customreasonphase/proxy")]
+        public Task GetWithCustomReasonPhase()
+        {
+            var options = HttpProxyOptionsBuilder.Instance.WithIntercept(
+                async (ctx) =>
+                {
+                    var httpResponseFeature = ctx.Features.Get<IHttpResponseFeature>();
+                    if (httpResponseFeature != null)
+                    {
+                        httpResponseFeature.ReasonPhrase = "I am dummy!";
+                    }
+
+                    return true;
+
+                }).Build();
+
+            return this.HttpProxyAsync("https://postman-echo.com/post", options);
+        }
+
+
         [Route("api/controller/timeoutclient/{postId}")]
         public Task GetWithTimeoutClient(int postId)
         {

src/Test/Http/HttpIntegrationTests.cs

@@ -206,6 +206,15 @@ public async Task CanGetIntercept()
             Assert.Equal("This was intercepted and not proxied!", await response.Content.ReadAsStringAsync());
         }
 
+        [Fact]
+        public async Task CanProxyReasonPhase()
+        {
+            var response = await _client.GetAsync("api/controller/customreasonphase/proxy");
+
+            response.EnsureSuccessStatusCode();
+            Assert.Equal("I am dummy!", response.ReasonPhrase);
+        }
+
         [Fact]
         public async Task CanProxyConcurrentCalls()
         {