Wider callsite span

[laurmaedje]

The compiler now uses the whole function call span instead of just the argument span as the callsite span. As a result, errors in a function are now annotated not just on the arguments, but on the whole function, e.g.:

#panic("hello")
 ^^^^^^^^^^^^^^
 panicked with: "hello"

instead of

#panic("hello")
      ^^^^^^^^^
      panicked with: "hello"

As a result, the missing arguments errors are now also on the full function call:

#rgb(0, 3)
 ^^^^^^^^^
 missing argument: blue component

instead of

#rgb(0, 3)
    ^^^^^^
    missing argument: blue component

One might consider that a bit less desirable than what we had before, but I think it's fine and actually better in some cases, e.g. one where a missing argument would have been annotated on a content body. We now have

#let foo(x, y) = {}
#foo[]
 ^^^^^
    missing argument: y

instead of

#let foo(x, y) = {}
#foo[]
    ^^
    missing argument: y

[Dherse]

Interestingly, this is how #3307 works, which I assumed was a mistake in the VM🤔

[laurmaedje]

Interestingly, this is how #3307 works, which I assumed was a mistake in the VM🤔

Well, I guess it would have been if the goal is to replicate the behaviour on main 1-1, but it's not anymore. :)