Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler now uses the whole function call span instead of just the argument span as the callsite span. As a result, errors in a function are now annotated not just on the arguments, but on the whole function, e.g.:
#panic("hello") ^^^^^^^^^^^^^^ panicked with: "hello"
instead of
#panic("hello") ^^^^^^^^^ panicked with: "hello"
As a result, the missing arguments errors are now also on the full function call:
instead of
One might consider that a bit less desirable than what we had before, but I think it's fine and actually better in some cases, e.g. one where a missing argument would have been annotated on a content body. We now have
instead of