AWS Fargate provider #173
AWS Fargate provider #173
Conversation
Configurable task role via `iam.amazonaws.com/role`, which is also used by kube2iam.
Add configurable IAM role for pods
Configurable task execution role https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_execution_IAM_role.html
Store and retrieve container logs using Cloudwatch Logs
End-to-end test for the provider
Implement AWS Fargate provider end-to-end tests
| defer f.Close() | ||
|
|
||
| err = p.loadConfig(f) | ||
| return err |
There was a problem hiding this comment.
nit: could just be return p.loadConfig(f)
| config *rest.Config | ||
| err error | ||
| ) | ||
| var config *rest.Config |
There was a problem hiding this comment.
Fixing a few golint warnings. This definition of err was not used. Also restricted a few really long lines to 120 columns.
|
Hello, do you think we can complete the review and merge today? This PR is touching only 2 source files outside of AWS Fargate provider, and the changes there are trivial. As discussed in our meeting earlier this week, I am happy to be the maintainer of AWS Fargate provider and review any PRs from the community going forward. |
|
@ofiliz I'm good with merging it since it pass the build and basic unit tests. I plan to "Rebase and merge" the PR, so that the commit history is kept. Does it sound good to you? |
|
lgtm, thanks! |
|
Alright I'm going to do a quick pass through and then merge. |
|
perfect! Thanks @rbitia @robbiezhang @jessfraz |
This PR implements the official AWS Fargate provider for virtual-kubelet.
This initial release includes:
Important note:
Virtual-kubelet and the AWS Fargate virtual-kubelet provider are in very early stages of development.
DO NOT run the AWS Fargate provider in any Kubernetes or Fargate production environments.
We would like to especially thank @johanneswuerbach for his contributions.
Fixes #12