Sparql authorization cache fixes #450
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litvinovg
force-pushed
the
sparql_authorization_cache_fixes
branch
from
cd2e9f3
to
76bf6f5
Compare
|
Resolved merge conflict |
chenejac
previously approved these changes
Mar 28, 2024
There was a problem hiding this comment.
@litvinovg works for me.
I have run tests and it is passing. I have tried to revert changes in SparqlSelectQueryResultChecker class and tests are failing.
Only the code in the last commit has been reviewed. I have investigated a little bit other approaches in copying a set and there is no clear recommendation whether copy constructor or clone method are better approaches comparing to using addAll method (approach used here). Therefore, I would suggest keeping it as is.
gneissone
reviewed
Mar 28, 2024
home/src/main/resources/rdf/accessControl/firsttime/template_update_related_allowed_property.n3
Outdated
Show resolved
Hide resolved
litvinovg
force-pushed
the
sparql_authorization_cache_fixes
branch
from
76bf6f5
to
25430cd
Compare
chenejac
approved these changes
Apr 4, 2024
litvinovg
force-pushed
the
sparql_authorization_cache_fixes
branch
from
25430cd
to
4fa8966
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue
Additional notes
This PR is stacked on top of #444
Only the last commit is related to this PR.
What does this pull request do?
Fixes failing authorization checks due to corrupted sparql results cache.
What's new?
Fixed SparqlSelectQueryResultsChecker
Added tests to verify that issue is resolved.
Log cases when model wasn't provided as errors.
How should this be tested?
Interested parties
@VIVO-project/vivo-committers