feat: add colors flag to infrastructureLogging #13051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
|
Omg I'm fixing lints |
KENNYSOFT
force-pushed
the
infrastructurelogging-colors
branch
from
76137ee
to
34b00b3
Compare
KENNYSOFT
force-pushed
the
infrastructurelogging-colors
branch
from
34b00b3
to
1f45499
Compare
KENNYSOFT
force-pushed
the
infrastructurelogging-colors
branch
from
1f45499
to
72ba68c
Compare
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
add appendOnly flag add custom console add custom stream
sokra
approved these changes
Apr 6, 2021
|
@KENNYSOFT Thanks for your update. I labeled the Pull Request so reviewers will review it again. @sokra Please review the new changes. |
|
Thanks |
|
I've created an issue to document this in webpack/webpack.js.org. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12899
Since it's my first try of contribution to webpack, even if I looked carefully for impacted default values etc, there can exists some missed parts. Please review carefully for me to fix things. Thanks!
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
infrastructureLogging.colorsEnables/Disables colorful output.infrastructureLogging.appendOnlyOnly appends lines to the output. Avoids updating existing output e. g. for status messages.infrastructureLogging.streamStream used for logging output. Defaults to process.stderr.infrastructureLogging.consoleCustom console used for logging.