d-r: enable dirty-regions by default #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the all-or-nothing mode, which means that we repaint the entire screen if there's a single dirty region. Also, nofliptimeout=0 is set to ensure that we never flip without rendering. With these combined, this should be universally safe (and within spec) for all gfx cards/drivers. The main possible side-effect is the slow-motion effect brought about on slower cpus that can't keep up at times and produce wild timestamps. With our improved decoding and caching, this is now quite rare.
ghost
assigned
theuni
added a commit
that referenced
this pull request
Oct 2, 2012
d-r: enable dirty-regions by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As decided at devcon. Enable dirty-regions by default on all platforms.
This enables the all-or-nothing mode, which means that we repaint the entire
screen if there's a single dirty region.
Also, nofliptimeout=0 is set to ensure that we never flip without rendering.
With these combined, this should be universally safe (and within spec) for all
gfx cards/drivers.
The main possible side-effect is the slow-motion effect brought about on slower
cpus that can't keep up at times and produce wild timestamps. With our improved
decoding and caching, this is now quite rare.