Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][PVR][GUI] 'Next recording on ...' label time is not localized #19557

Merged
merged 1 commit into from Apr 10, 2021
Merged

Conversation

djp952
Copy link
Contributor

@djp952 djp952 commented Apr 10, 2021

Description

Backport of PR #19551 for Matrix branch

The "Next recording on..." label shown in the PVR Timers and PVR Timer Rules view does not localize the time portion of the label correctly:

Untitled

Motivation and Context

After a time consuming "deep" search, this concern has apparently existed since PVR was first implemented in Frodo via PR #1357. I searched the current PVR implementation and did not find any additional instances where the localized date/time format is being ignored, and do not have any other suggested edits to resolve.

How Has This Been Tested?

Tested on Kodi master branch current as of 2021.04.09, on Windows x64 (Desktop), with:

  • Settings / Interface / Regional / Regional default format -> USA (12h)
  • Settings / Interface / Regional / Time format --> Regional (h:mm:ss xx)

Screenshots (if appropriate):

Before the requested change, the time portion of the label shows as HH:mm on all platforms and regions:

Untitled

After the requested change the time portion of the label is localized based on Settings as expected:

Untitled2

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@djp952 djp952 requested a review from ksooo as a code owner April 10, 2021 16:28
@ksooo ksooo added Component: PVR Type: Backport Type: Fix non-breaking change which fixes an issue v19 Matrix labels Apr 10, 2021
@ksooo ksooo added this to the Matrix 19.1 milestone Apr 10, 2021
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phunkyfish phunkyfish added Type: Fix non-breaking change which fixes an issue and removed Type: Fix non-breaking change which fixes an issue labels Apr 10, 2021
@phunkyfish phunkyfish merged commit 8af5d06 into xbmc:Matrix Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Type: Backport Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants