New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pvr] Radio RDS support #6174
[pvr] Radio RDS support #6174
Conversation
Hello all, can someone help me to add windows and other OS Build files? Thanks a lot |
03620f8
to
08bb7de
Compare
@AlwinEsch I can do the Windows changes, I've been meaning to test this as soon as I have time (have a spare RTL2832 stick that I haven't found any use for until now). |
967d5d9
to
fd7750c
Compare
@Jalle19 thanks |
13b27ed
to
6726ba4
Compare
Ping @ronie for the skinning parts |
I take it the PVR addon can only be used on Linux, and the backend cannot be separated from the client? I'm trying to figure out how to test this since I don't have an antenna jack near my HTPC. |
only did a quick sanity check of the files changed, not the new ones. @Jalle19 why would this only work on a local backend on linux? it's just stream data? |
@opdenkamp I was actually referring to the addon he made. |
@Jalle19 has seen that the needed library is also available for windows (http://sdr.osmocom.org/trac/attachment/wiki/rtl-sdr/RelWithDebInfo.zip), thats why i thought is also compatible. Has set in cmake file only a compiler improve for gcc but this system is new for me and no idea how this is handled in windows. @opdenkamp thanks for the comments, I perform currently a cleanup. |
@AlwinEsch cool, didn't know there was a Windows library for it. I'd love to be able to have the RTL stick plugged into the server and use the addon on any client, but it seems that's not possible since it interfaces directly with the hardware. |
dc75797
to
5080797
Compare
@opdenkamp have cleaned up based upon your comments and changed the RDS info tag to a shared_ptr and only one present on related stream class. Is nice. Is also the Music Info tag planned to use this way? Currently the Artist and Title on this becomes set from RDS stream if present (RT+). |
i would drop the genre specific backgrounds from confluence. |
Hello @ronie thanks for the comments, I do a cleanup in the next days. With the backgrounds was from me to have the dialog not always complete empty. If a radio is heard a longer time and the radio send a lot of infos it can be complete full, but most time it is only this. With 3 was my idea only to know how it looks and to add maybe later more. |
f39d291
to
fdb767e
Compare
thanx for the fixes! :-) one more thing i forgot to ask, why did you add a complete new window to the PVR section (MyPVRRadioChannels.xml)? can't you just add the new view to MyPVRChannels.xml? |
844af86
to
d45051d
Compare
Is updated with current xbmc branch and the numbers removed. |
fad1934
to
ca713bf
Compare
4c03687
to
eba1821
Compare
c810a66
to
7eb0611
Compare
7eb0611
to
e878546
Compare
Pull request is updated to the latest kodi version and tested, seems to be still ok. jenkins build this please |
#define SPIN_CONTROL_INFO 21 | ||
#define TEXT_INFO 22 | ||
#define CONTROL_NEXT_PAGE 60 | ||
#define CONTROL_INFO_LIST 70 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Does it work for DVB-T2 radio channels? |
This changes implement handling about RDS signal from Radio. The related data need to be send with other streams from add-on and become handled inside DVDPlayer.
Data become then translated and stored in own file Item information tag and can be used from skin and other add-ons over GUIInfoManager. Also if Radiotext plus is present, the Music Artist and Title on MusicInfoTag become set. Further is for Radiotext+ a new dialog present. For this are also 3 background images (currently only 3, it gives 32 genres on RDS).
The normal Radiotext become shown on PVR channels window. For this is on skin a setting to show only EPG or RDS and if setting there enabled are both on two places
Further support this the RaSS images send from RDS (currently only German SWR).
If on settings enabled the traffic messages can be passed outside. Allow to create a add-on which can handle related data.
The needed data format is Universal Encoder Communication Protocol (UECP SPB 490).
Have created a new add-on which use the library from RTL-SDR (http://sdr.osmocom.org/trac/wiki/rtl-sdr) to handle FM Radio with RDS and also created changes on VDR VNSI addon and related source plugin.
Findable currently under following links:
Also are on Patch 6 and 7 changes not direct related to this request.
The first is a hack to open add-on channel settings dialogues (I don't like this way!), searched also with the ADSP about the problem. With a for me unknown reason a add-on dialogue becomes always opened behind KODI's one.
The second allow the usage from PVR related buttons over the Music OSD dialogue.
Here are some screen shots:
PVR radio window
Full screen view with add-on signal
RaSS information image and also enabled for EPG (currently I have no channel with EPG thats why empty)
Dialogue which can show the information from RT+ (most present until now under classical radio).
PVR settings
Settings on skin