Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[guilib][depends] Remove libgif from core. #9055

Merged
merged 2 commits into from Feb 5, 2016

Conversation

ace20022
Copy link
Member

@ace20022 ace20022 commented Feb 5, 2016

It's still needed for TexturePacker.

@ace20022
Copy link
Member Author

ace20022 commented Feb 5, 2016

@stefansaraev Not sure if this is enough/correct for texturepacker, could you please have a look?

@razzeee razzeee added Component: Depends Component: GUI engine Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v17 Krypton labels Feb 5, 2016
@stefansaraev
Copy link
Contributor

I am quite sure giflib for target can be removed. just keep giflib-native as-is.

and perhaps you should not touch docs/README.* - giflib is still needed on ubuntu / regular linux.

EDIT: I started manual jenkins build from my branch (which is same as yours + I have http://sprunge.us/NMVI) and jenkins was happy. so yes. giflib-native is enough,

@@ -49,7 +49,7 @@ Build-Depends: autoconf, automake, autopoint, autotools-dev, cmake, curl,
libbluray-dev (>= 0.7.0), libbz2-dev, libcap-dev,
libcdio-dev, libcec-dev, libcurl4-openssl-dev | libcurl4-gnutls-dev | libcurl-dev,
libcwiid-dev, libdbus-1-dev, libegl1-mesa-dev, libfontconfig-dev, libfreetype6-dev,
libfribidi-dev, libgif-dev (>= 4.1.6), libgl1-mesa-dev | libgl-dev, libglu1-mesa-dev | libglu-dev,

This comment was marked as spam.

@ace20022
Copy link
Member Author

ace20022 commented Feb 5, 2016

jenkins build this please

@ace20022
Copy link
Member Author

ace20022 commented Feb 5, 2016

@wsnipex @stefansaraev thx for the help! Good to go?

@wsnipex
Copy link
Member

wsnipex commented Feb 5, 2016

looks good to me

stefansaraev added a commit that referenced this pull request Feb 5, 2016
 [guilib][depends] Remove libgif from core.
@stefansaraev stefansaraev merged commit a052938 into xbmc:master Feb 5, 2016
@ace20022 ace20022 deleted the remove_giflib branch February 5, 2016 14:35
@razzeee razzeee added this to the Krypton 17.0-alpha1 milestone Feb 5, 2016
garbear added a commit to garbear/steamlink-sdk-old that referenced this pull request Dec 21, 2016
Also, libgif has been removed from the target deps:

xbmc/xbmc#9055
garbear added a commit to garbear/steamlink-sdk-old that referenced this pull request Dec 22, 2016
libgif has been removed from the target deps:

xbmc/xbmc#9055

librtmp has been removed from native deps because it's included with ffmpeg:

xbmc/xbmc#11149
garbear added a commit to garbear/steamlink-sdk-old that referenced this pull request Dec 25, 2016
libgif has been removed from the target deps:

xbmc/xbmc#9055

librtmp has been removed from native deps because it's included with ffmpeg:

xbmc/xbmc#11149
garbear added a commit to garbear/steamlink-sdk-old that referenced this pull request Dec 25, 2016
libgif has been removed from the target deps:

xbmc/xbmc#9055

librtmp has been removed from native deps because it's included with ffmpeg:

xbmc/xbmc#11149
HiassofT added a commit to HiassofT/LibreELEC.tv that referenced this pull request Sep 6, 2020
giflib support was dropped in kodi 17 (only texturepacker on
buildhost still needs giflib).

See xbmc/xbmc#9055

Signed-off-by: Matthias Reichl <hias@horus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Depends Component: GUI engine Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v17 Krypton
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants