[depends] remove rtmp as it's included through ffmpeg or as binary addon #11149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartijnKaijser
added
Type: Backport
Type: Cleanup
|
jenkins build this please |
wsnipex
approved these changes
Dec 12, 2016
|
@MartijnKaijser we tried this about 6 months back and system info on android tv was still using it so system information page was freezing, do you remember. will give it a shot again though. was using lib/librtmp.so i dunno why. |
|
Not sure what you mean cause it runs just fine |
|
@MartijnKaijser ok ill post a debug log if it freezes again, it was on android tv as soon as you go system information page in settings it would freeze, it was related to librtmp.so being removed. can i get a krypton test build plz. |
|
use the nightly |
|
@MartijnKaijser OK just ran it and tested it appears fine now. it caused problems months ago though when they tried a cleanup. i cant find the PR for reference. |
garbear
added a commit
to garbear/steamlink-sdk-old
that referenced
this pull request
Dec 22, 2016
libgif has been removed from the target deps: xbmc/xbmc#9055 librtmp has been removed from native deps because it's included with ffmpeg: xbmc/xbmc#11149
garbear
added a commit
to garbear/steamlink-sdk-old
that referenced
this pull request
Dec 25, 2016
libgif has been removed from the target deps: xbmc/xbmc#9055 librtmp has been removed from native deps because it's included with ffmpeg: xbmc/xbmc#11149
garbear
added a commit
to garbear/steamlink-sdk-old
that referenced
this pull request
Dec 25, 2016
libgif has been removed from the target deps: xbmc/xbmc#9055 librtmp has been removed from native deps because it's included with ffmpeg: xbmc/xbmc#11149
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just throwing it out here. Up to others to say merge or not.
the inputstream.rtmp addon builds on all platforms so we don't need this anymore