-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[depends] remove rtmp as it's included through ffmpeg or as binary addon #11149
[depends] remove rtmp as it's included through ffmpeg or as binary addon #11149
Conversation
jenkins build this please |
@MartijnKaijser we tried this about 6 months back and system info on android tv was still using it so system information page was freezing, do you remember. will give it a shot again though. was using lib/librtmp.so i dunno why. |
Not sure what you mean cause it runs just fine |
@MartijnKaijser ok ill post a debug log if it freezes again, it was on android tv as soon as you go system information page in settings it would freeze, it was related to librtmp.so being removed. can i get a krypton test build plz. |
use the nightly |
@MartijnKaijser OK just ran it and tested it appears fine now. it caused problems months ago though when they tried a cleanup. i cant find the PR for reference. |
libgif has been removed from the target deps: xbmc/xbmc#9055 librtmp has been removed from native deps because it's included with ffmpeg: xbmc/xbmc#11149
libgif has been removed from the target deps: xbmc/xbmc#9055 librtmp has been removed from native deps because it's included with ffmpeg: xbmc/xbmc#11149
libgif has been removed from the target deps: xbmc/xbmc#9055 librtmp has been removed from native deps because it's included with ffmpeg: xbmc/xbmc#11149
Just throwing it out here. Up to others to say merge or not.
the inputstream.rtmp addon builds on all platforms so we don't need this anymore