Hardcode connectors' filenames #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. as they don't change often and is waste of resources to loop on then on each run, also to maintain interoperability #517
|
@fjarrett @westonruter What do you think about this one ? |
|
@shadyvb I think it is fine, though a simpler alternative would be to grab the basename of each result of the glob, and then prefixing each array item with the absolute path to the directory after it is get/set from the cache. |
|
@westonruter I thought we'd drop the |
|
@shadyvb yeah, that's fine 😄 |
|
Tested and working in single site and multisite. |
fjarrett
added a commit
that referenced
this pull request
May 10, 2014
Hardcode connectors' filenames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. as they don't change often and is waste of resources to loop on then on
each run, also to maintain interoperability #517