Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging changes of settings in Customizer #827

Merged
merged 3 commits into from Mar 10, 2016
Merged

Conversation

lukecarbis
Copy link
Contributor

Resolves #308.

Thanks @marcin-lawrowski for finding this. I've tested it and it works well.

@westonruter Would you mind reviewing this one-liner? Any unintended side-effects?

@westonruter
Copy link
Contributor

Using the customize_save action is a good way to capture whether the setting updates are being made in the Customizer, yes: https://github.com/xwp/wordpress-develop/blob/deaabdcc28bfbdc78d90040ece81250563b84779/src/wp-includes/class-wp-customize-manager.php#L999-L1020

The PHPDoc will need to be updated from:

Trigger this connector from WP CLI, only for known Settings

@lukecarbis
Copy link
Contributor Author

Good catch. Thanks @westonruter.

lukecarbis pushed a commit that referenced this pull request Mar 10, 2016
Logging changes of settings in Customizer
@lukecarbis lukecarbis merged commit 3d5140c into develop Mar 10, 2016
@lukecarbis lukecarbis deleted the bugfix/issue-308 branch March 10, 2016 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants