Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing Stream for Alternate Database Drivers #889

Merged
merged 29 commits into from Feb 15, 2017
Merged

Conversation

lukecarbis
Copy link
Contributor

See #881.

Moving here for extra work and testing.

eugenekireev and others added 27 commits December 15, 2015 16:01
abstracted db class interface, so it is configurable
Conflicts:
	classes/class-db.php
	classes/class-query.php
…p, since that work was moved a level deeper
…storage functions. These run the same install and uninstall functionality the plugin already has in place, but since it's now calling it from the Driver class, it can be overridden by other drivers.
Preparing Stream for Alternate Database Drivers
@lukecarbis lukecarbis self-assigned this Oct 31, 2016
@lukecarbis
Copy link
Contributor Author

lukecarbis commented Oct 31, 2016

@dkotter Have you got an example Stream Add-On that uses the wp_stream_db_driver filter to attach a different database driver?

@lukecarbis lukecarbis modified the milestone: 3.1.2 Nov 2, 2016
@lukecarbis
Copy link
Contributor Author

@dkotter ping.

@dkotter
Copy link
Contributor

dkotter commented Nov 7, 2016

So we do have one that we are working on at 10up, but currently it's in a private repo. I believe we were waiting for these changes to land in Stream first before making that public, because without these changes, the plugin itself won't do anything.

Once these changes are live and we've thoroughly tested our plugin, we'll be happy to make that public and that can be used as an example of how to build an add-on.

@lukecarbis
Copy link
Contributor Author

@dkotter I've reached out on WP Slack. If you could get me a copy to test this branch out privately - even if its a stripped back basic version - that would be much appreciated.

@lukecarbis
Copy link
Contributor Author

Ping @dkotter

@tlovett1
Copy link
Contributor

tlovett1 commented Jan 6, 2017

@lukecarbis we just sent you an invite to the repo.

@lukecarbis lukecarbis merged commit c284f36 into develop Feb 15, 2017
@lukecarbis lukecarbis deleted the db-driver branch February 15, 2017 04:15
@tlovett1
Copy link
Contributor

tlovett1 commented Mar 6, 2017

Hey @lukecarbis when will this make it into a released version?

@lukecarbis
Copy link
Contributor Author

Today. :)

@Japh
Copy link

Japh commented Mar 15, 2017

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants