Add Slack alert implementation #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of this [`array_filter`](https://github.com/WordPress/WordPress/blob/master/wp-includes/class-wp-user.php#L474) call, `$old_roles`'s first member might not always be at the zero index ( if it is not actually a valid role ).
Fix WP_CLI namespace collision
Fix a notice where $old_roles indices are not properly sorted
|
Wow, nice. Unfortunately the development team here seems to be super-busy with other projects. Anybody here know what the future plans are for Stream? Itmw, I will patch my copies with this, and test it on a couple of production situations. Will report back once done. |
|
@robbiet480 This is very nice. Would it be possible for you to clean up the code to adhere to the required coding standards so that they pass the build? Thanks! |
DavidCramer
requested changes
Apr 3, 2018
|
Is the |
|
@lkraav it was? where? |
|
Only thing I see is addition of |
|
ye, and that is intentional. oh well. The new PR is here #970 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the old "Stream to Slack" plugin that didn't have any kind of alerting options or rich notifications, this does. Rich notifications look like this: