Add grunt build and .min prefix to scripts and styles #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukecarbis
suggested changes
Apr 19, 2018
There was a problem hiding this comment.
@DavidCramer Minimising and adding a grunt build is well overdue! Thanks for your comprehensive changes.
Could you please also ammend the README to include setup, build, and deployment instructions (npm init, the various grunt tasks, etc.)?
|
#975 Needs to be merged before this (to resolve the failing Travis build). |
lukecarbis
approved these changes
Apr 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lukecarbis - There may be a merge conflict here since I branched from master, and there are some unit test issues. But, it can still be reviewed and I'll fix any issues if needed.
Addresses #942