Skip to content
This repository has been archived by the owner on Dec 27, 2022. It is now read-only.

Add workaround to pretend customize_save ajax action is happening during changeset publishing #137

Merged
merged 1 commit into from Jul 13, 2017
Merged

Add workaround to pretend customize_save ajax action is happening during changeset publishing #137

merged 1 commit into from Jul 13, 2017

Conversation

westonruter
Copy link
Contributor

To quote from https://core.trac.wordpress.org/ticket/39221#comment:14

Anne Louise Currie found a defect in core related to this, specifically in publishing a changeset from outside the Customizer, such as via the edit post screen as provided by the Customize Snapshots plugin. In particular, publishing changes to options will fail due to the preview filters being added.

I have amended the PR with a fix: xwp/wordpress-develop@3e4dea4

This PR implements a hacky workaround to make sure that preview logic is not invoked for settings.

PatelUtkarsh
PatelUtkarsh approved these changes Jul 13, 2017
View reviewed changes
Copy link
Member

@PatelUtkarsh PatelUtkarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@westonruter westonruter modified the milestone: 0.6.1 Jul 13, 2017
@westonruter westonruter merged commit dc978f9 into develop Jul 13, 2017
@westonruter westonruter deleted the fix/changeset-publishing-preview-prevention branch July 13, 2017 18:59
@westonruter westonruter mentioned this pull request Jul 14, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PatelUtkarsh PatelUtkarsh PatelUtkarsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@westonruter @PatelUtkarsh