Skip to content
This repository has been archived by the owner on Dec 27, 2022. It is now read-only.

Upgrade for WP 4.9 and remove back-compat for <4.7 #162

Merged
merged 57 commits into from Nov 16, 2017
Merged

Conversation

westonruter
Copy link
Contributor

@westonruter westonruter commented Oct 21, 2017

  • Conditionally incorporate [WIP] 4.9 Refactoring Test #161 when on 4.9+.
  • Make sure features not merged into core are ported into customize-snapshots.js, including changeset title and saving the current previewed URL and expanded panels/sections as meta when saving a changeset, etc.
  • Fix autosave requests. They currently fail with a changeset_post_save_failure for edit_others_posts. There is some conflict between setting the caps in \CustomizeSnapshots\Post_Type::extend_changeset_post_type_object() and the logic to in \WP_Customize_Manager::grant_edit_post_capability_for_changeset() when performing an autosave request.
  • Update changeset title when user sitting on customizer and schedule time arrived.
  • Test and fix how pending state is saved when user does not have publish capability.

Testing:

  • Test if able to publish changeset from front end in compat and 4.9
  • Test if able to merge changesets in compat and 4.9
  • Test if snapshot admin post edit screen is working as expected in compat and 4.9
  • Test state query vars are saved properly in compat and 4.9
  • Test if able to create multiple changesets in compat and 4.9
  • Overall testing

Also fix add_snapshot_uuid_to_return_url logic to only include customize_changeset_uuid in return_url when referer had it to begin with.
@coveralls
Copy link

coveralls commented Oct 21, 2017

Coverage Status

Coverage increased (+5.4%) to 80.279% when pulling 922a1ad on upgrade/4.9 into 3076044 on develop.

@coveralls
Copy link

coveralls commented Oct 23, 2017

Coverage Status

Coverage increased (+5.4%) to 80.279% when pulling 081e066 on upgrade/4.9 into 3076044 on develop.

@westonruter westonruter added this to the 0.7.0 milestone Oct 30, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+5.5%) to 80.357% when pulling 3993bff on upgrade/4.9 into 3076044 on develop.

1 similar comment
@coveralls
Copy link

coveralls commented Oct 30, 2017

Coverage Status

Coverage increased (+5.5%) to 80.357% when pulling 3993bff on upgrade/4.9 into 3076044 on develop.

@coveralls
Copy link

coveralls commented Nov 2, 2017

Coverage Status

Coverage increased (+5.5%) to 80.377% when pulling 54059d2 on upgrade/4.9 into 3076044 on develop.

@mohdsayed mohdsayed removed their request for review November 2, 2017 12:18
@coveralls
Copy link

coveralls commented Nov 2, 2017

Coverage Status

Coverage increased (+5.5%) to 80.377% when pulling 0b5ef52 on upgrade/4.9 into 3076044 on develop.

@coveralls
Copy link

coveralls commented Nov 8, 2017

Coverage Status

Coverage increased (+5.5%) to 80.377% when pulling 86722c8 on upgrade/4.9 into 3076044 on develop.

@coveralls
Copy link

coveralls commented Nov 8, 2017

Coverage Status

Coverage increased (+5.5%) to 80.377% when pulling d471abf on upgrade/4.9 into 3076044 on develop.

@coveralls
Copy link

coveralls commented Nov 14, 2017

Coverage Status

Coverage increased (+6.0%) to 80.859% when pulling 868b6b5 on upgrade/4.9 into 3076044 on develop.

@coveralls
Copy link

coveralls commented Nov 14, 2017

Coverage Status

Coverage increased (+6.0%) to 80.859% when pulling 18514d5 on upgrade/4.9 into 3076044 on develop.

@coveralls
Copy link

coveralls commented Nov 14, 2017

Coverage Status

Coverage increased (+6.007%) to 80.892% when pulling 558ef8f on upgrade/4.9 into 3076044 on develop.

@coveralls
Copy link

coveralls commented Nov 14, 2017

Coverage Status

Coverage increased (+5.3%) to 80.211% when pulling 558ef8f on upgrade/4.9 into 3076044 on develop.

@coveralls
Copy link

coveralls commented Nov 14, 2017

Coverage Status

Coverage increased (+5.3%) to 80.211% when pulling 96b247e on upgrade/4.9 into 3076044 on develop.

@westonruter
Copy link
Contributor Author

@sayedtaqui anything left here as far as you know?

@mohdsayed
Copy link
Contributor

I think this is it. I will do more testing before you wake up.

@coveralls
Copy link

coveralls commented Nov 15, 2017

Coverage Status

Coverage increased (+5.3%) to 80.211% when pulling 026839a on upgrade/4.9 into 3076044 on develop.

@coveralls
Copy link

coveralls commented Nov 15, 2017

Coverage Status

Coverage increased (+5.3%) to 80.211% when pulling 026839a on upgrade/4.9 into 3076044 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.3%) to 80.211% when pulling da511c4 on upgrade/4.9 into 3076044 on develop.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+5.3%) to 80.211% when pulling da511c4 on upgrade/4.9 into 3076044 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.3%) to 80.211% when pulling da511c4 on upgrade/4.9 into 3076044 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.3%) to 80.211% when pulling da511c4 on upgrade/4.9 into 3076044 on develop.

@coveralls
Copy link

coveralls commented Nov 15, 2017

Coverage Status

Coverage increased (+5.3%) to 80.211% when pulling a2a1ee7 on upgrade/4.9 into 3076044 on develop.

@coveralls
Copy link

coveralls commented Nov 16, 2017

Coverage Status

Coverage increased (+5.3%) to 80.211% when pulling 952a754 on upgrade/4.9 into 3076044 on develop.

@westonruter westonruter merged commit feba7ab into develop Nov 16, 2017
@westonruter westonruter deleted the upgrade/4.9 branch November 16, 2017 06:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants