PRs from youtube-dl

[coletdjnz]

There are many pull requests being made upstream that are not being merged lately but could be of interest to merge here.

We're making this discussion as a place to @ the authors of PRs of interest to see if they want to bring their PR over here. It can make it faster & easier to get it merged if the original PR dev is willing to work with us.

Feel free to also take feedback/changes made here back upstream as well 😃

[coletdjnz]

@sbor23 feel free to submit your playsuisse extractor PR from youtube-dl here (if it still works): ytdl-org/youtube-dl#28142. I believe yt-dlp has the capabilities to support the required type of subtitle extraction too.

[sbor23]

There you go: #845

[coletdjnz]

@memo33 feel free to submit your tagesschau extractor PR from youtube-dl here (if it still works) ytdl-org/youtube-dl#28435

[coletdjnz]

Hi all! Feel free to submit your PR's linked from youtube-dl here (if they still work and you are still willing to finish them off) 😃
@poschi3 gotostage: ytdl-org/youtube-dl#26617
@peat-psuwit bigo: ytdl-org/youtube-dl#29064 (we can help with your q's)
@foodcourt2021 sohu: ytdl-org/youtube-dl#29087
@cyberfox1691 murrtube: ytdl-org/youtube-dl#27545
@dalanmiller ninenow: ytdl-org/youtube-dl#28831

[poschi3]

@coletdjnz Thanks! There you go: #883

[dalanmiller]

Thanks for the ping!: #896

[peat-psuwit]

ytdl-org/youtube-dl#29064 has been re-submitted as #933 . Both of the questions are added back to the PR.

[Ashish0804]

Some more PRs that can be made here
@chao813 ytdl-org/youtube-dl#29947
@robotman771 ytdl-org/youtube-dl#29914
@dirkf ytdl-org/youtube-dl#29757

[chao813]

@Ashish0804 Thanks! Its here: #981

[coletdjnz]

@rsola feel free to submit your atresplayer PR here - ytdl-org/youtube-dl#27215

This should fix #996 too.

[rsola]

Hello. Let me a few days to try yt-dlp and study its code.

[pukkandan]

It's basically the same as youtube-dl. The main difference for your PR would be that we have a function _extract_mpd_formats_and_subtitles and so your subtitle code can probably be dropped

But yeah, take your time :)

[rsola]

Done. PR #1165.

[pukkandan]

DO NOT post unrelated comments here. This has nothing to do with this thread. The instructions for running from master branch are in the README. And if you are not able to follow it, wait for the new release

[coletdjnz]

Read the above message. DO NOT post unrelated comments here. Look into creating a new issue if applicable and one doesn't already exist.

[fstirlitz]

kikuyan has recently deleted their account with a number of pull requests open:

• Add hidden --load-webpage option for debug purposes ytdl-org/youtube-dl#30529 (add-load-webpage-option, ytdl-org/youtube-dl@89854c6)
• [extractor/common] add SocialMediaPosting type to _json_ld() ytdl-org/youtube-dl#30513 (add-social-type-to-json-ld, ytdl-org/youtube-dl@75804e2)
• [utils] add --raw to setfattr ytdl-org/youtube-dl#30498 (setfattr-raw, ytdl-org/youtube-dl@2600250)
• [downloader/hls] fix to do unpad after decrypt ytdl-org/youtube-dl#30488 (fix-hlsnative-decrypt, ytdl-org/youtube-dl@6f1e7d7)
• [extractor/videa] fix extraction ytdl-org/youtube-dl#30418 (fix-videa-extract, ytdl-org/youtube-dl@edbee17)
• [utils] remove Accept-Charset http header ytdl-org/youtube-dl#30394 (remove-accept-charset, ytdl-org/youtube-dl@989c355)
• [options] modify --get-thumbnail option name to --get-thumbnail-url ytdl-org/youtube-dl#30356 (modify-get-thumb-optname, ytdl-org/youtube-dl@a590f6e)
• [postprocessor] modify severities of embedding subtitles and thumbnail ytdl-org/youtube-dl#30351 (modify-embed-subs-thumbs-severities, ytdl-org/youtube-dl@817f905)
• [YoutubeDL] modify messages for subtitles and thumbnails ytdl-org/youtube-dl#30331 (modify-subs-thumbs-msgs, ytdl-org/youtube-dl@e638517)
• [YoutubeDL] catch errors on --load-info-json ytdl-org/youtube-dl#30321 (catch-load-info-error, ytdl-org/youtube-dl@ed8ce06)
• [options] modify help text for --external-downloader ytdl-org/youtube-dl#30304 (help-external-downloader, ytdl-org/youtube-dl@f9e6c9f)
• Add checks for external downloader ytdl-org/youtube-dl#30302 (check-external-downloader, ytdl-org/youtube-dl@4c4e9c8)
• [YoutubeDL] modify fixup warning message ytdl-org/youtube-dl#30298 (modify-fixup-warning, ytdl-org/youtube-dl@52774c3)
• modify post-processing for MPEG-DASH ytdl-org/youtube-dl#30297 (fixup-mpeg-dash, ytdl-org/youtube-dl@5adea4b)
• support byte range for dash mpd ytdl-org/youtube-dl#30279 (support-range-for-dash, ytdl-org/youtube-dl@6873ba9)
• improve post-processing for HLS ytdl-org/youtube-dl#30270 (improve-hls-postproc, ytdl-org/youtube-dl@128ecbf)
• [extractor/phoenix.de] improve extraction ytdl-org/youtube-dl#30209 (improve-phoenix-extraction, ytdl-org/youtube-dl@478db7f)
• [extractor/mtv] fix mgid extraction ytdl-org/youtube-dl#30149 (fix-mtv-mgid-extraction, ytdl-org/youtube-dl@5e66c23)
• [tv2] fix extraction ytdl-org/youtube-dl#29939 (easy-fix-tv2, ytdl-org/youtube-dl@159f2c7)
• [downloader/external] add streamlink support (HLS only) ytdl-org/youtube-dl#29908 (add-streamlink-support, ytdl-org/youtube-dl@28ff4c8)
• [vlive:channel] fix extraction (update api) ytdl-org/youtube-dl#29866 (fix-vlive-channel, ytdl-org/youtube-dl@ee7f1dc)
• [extractor/facebook] improve extraction ytdl-org/youtube-dl#29796 (improve-facebook-metadata, ytdl-org/youtube-dl@4819180)
• [extractor/instagram] several improvements ytdl-org/youtube-dl#29751 (improve-instagram, ytdl-org/youtube-dl@64d1fb1)
• [extractor/vbox7] improve extraction ytdl-org/youtube-dl#29680 (improve-vbox7, ytdl-org/youtube-dl@f8a6f44)
• [servus] change to site new url and update api url ytdl-org/youtube-dl#29556 (change-servustv-url, ytdl-org/youtube-dl@26611a0)

Many of them we already had applied or fixed in other ways, but is there anything worthwhile there?

[Ashish0804]

Probably not. Especially when dlp is quite diff from dl now.
I don't think looking at ytdl PRs makes sense anymore (maybe new extractors to stretch it)
If there are any major breaking changes with an extractor, then users will report.
No point in going out and looking for things to fix especially when dlp itself have 50+ open PRs and 300+ issues

[fstirlitz]

Even if they cannot be merged directly, maybe they may point to issues we may have overlooked ourselves. For example, ytdl-org/youtube-dl#30235, fixed by ytdl-org/youtube-dl#30279, is reproducible with latest yt-dlp git master.

[pukkandan]

Core changes

• [utils] add --raw to setfattr ytdl-org/youtube-dl#30498
• modify post-processing for MPEG-DASH ytdl-org/youtube-dl#30297
• [downloader/external] add streamlink support (HLS only) ytdl-org/youtube-dl#29908
• Video from MPEG-DASH stream much larger than same video from HLS stream ytdl-org/youtube-dl#30235 - support byte range for dash mpd ytdl-org/youtube-dl#30279

QOL changes

• [postprocessor] modify severities of embedding subtitles and thumbnail ytdl-org/youtube-dl#30351
• [YoutubeDL] modify messages for subtitles and thumbnails ytdl-org/youtube-dl#30331
• [YoutubeDL] catch errors on --load-info-json ytdl-org/youtube-dl#30321
• [YoutubeDL] modify fixup warning message ytdl-org/youtube-dl#30298

Known extractor issues

• [Broken] Vbox7 issues  #1098 [extractor/vbox7] improve extraction ytdl-org/youtube-dl#29680
• Issues of facebook metadata that was reported to yt-dlp was fixed already. Will need to see if these improve upon it [extractor/facebook] improve extraction ytdl-org/youtube-dl#29796, [extractor/common] add SocialMediaPosting type to _json_ld() ytdl-org/youtube-dl#30513

Other extractor changes

• [extractor/phoenix.de] improve extraction ytdl-org/youtube-dl#30209
• [tv2] fix extraction ytdl-org/youtube-dl#29939

Already fixed, but may be worth looking into differences in implementation

• improve post-processing for HLS ytdl-org/youtube-dl#30270

Do not merge

• [options] modify --get-thumbnail option name to --get-thumbnail-url ytdl-org/youtube-dl#30356
• [extractor/videa] fix extraction ytdl-org/youtube-dl#30418

Already merged / Fixed separately

• Add checks for external downloader ytdl-org/youtube-dl#30302
• Add hidden --load-webpage option for debug purposes ytdl-org/youtube-dl#30529
• [downloader/hls] fix to do unpad after decrypt ytdl-org/youtube-dl#30488
• [utils] remove Accept-Charset http header ytdl-org/youtube-dl#30394
• [options] modify help text for --external-downloader ytdl-org/youtube-dl#30304
• [extractor/instagram] several improvements ytdl-org/youtube-dl#29751
• [vlive:channel] fix extraction (update api) ytdl-org/youtube-dl#29866
• [extractor/mtv] fix mgid extraction ytdl-org/youtube-dl#30149
• [servus] change to site new url and update api url ytdl-org/youtube-dl#29556

[pukkandan]

No point in going out and looking for things to fix especially when dlp itself have 50+ open PRs and 300+ issues

I agree with this for extractor changes. It is not worth it to spend time looking into site breakages unless they are reported here. Core issues in upstream should however be given attention imo

[fstirlitz]

Already fixed, but may be worth looking into differences in implementation

• support byte range for dash mpd ytdl-org/youtube-dl#30279

Fragment downloader supports downloading byte ranges, but I don’t see our DASH client look at the range or mediaRange attributes at all.