Pass keywords through call stack #7733
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
headius
force-pushed
the
propagate_kwargs
branch
from
c56f1bf
to
377267f
Compare
headius
force-pushed
the
propagate_kwargs
branch
from
86484e4
to
9b521f2
Compare
headius
force-pushed
the
propagate_kwargs
branch
from
9b521f2
to
0234742
Compare
This is an attempt to start passing callInfo (flags for keyword arguments calls) through the call stack to bring it closer to the target method body. This will allow us to perform appropriate keyword munging on the receiver side without having to store the callInfo in ThreadContext and clear it when done. We can also introduce new encodings for kwargs, such as directly in the args array rather than pre-packaging in a Hash at the point of call.
headius
force-pushed
the
propagate_kwargs
branch
from
0234742
to
1e6829d
Compare
Different types of methods will have different mechanisms for passing the kwargs callInfo along. * "Generic" handles just using DynamicMethod.call can use the forms that take int callInfo. All existing implementations of that set the thread-local anyway, but we have at least pushed the flags up to this point. * Jitted Ruby methods do not yet accept callInfo as a paramter so all such calls should be wrapped by callInfo thread-local. * Native core methods do not yet accept callInfo as a parameter so all such calls should be wrapped by callInfo thread-local. * Construction with new/initialize does not yet accept callInfo as a parameter so all such calls should be wrapped by callInfo thread-local. I do not believe any other cases being built for indy dispatch right now end up in core that cares about keywords, so the flags do not need to be set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will attempt to pass enough information on the call stack that we can eliminate the thread-local
callInfostate, which must be set before each call and cleared immediately upon entering the target body.