Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass keywords through call stack #7733

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Pass keywords through call stack #7733

wants to merge 2 commits into from

Commits on Nov 9, 2023

  1. Start propagating callInfo through call path 

    This is an attempt to start passing callInfo (flags for keyword
arguments calls) through the call stack to bring it closer to the
target method body. This will allow us to perform appropriate
keyword munging on the receiver side without having to store the
callInfo in ThreadContext and clear it when done. We can also
introduce new encodings for kwargs, such as directly in the args
array rather than pre-packaging in a Hash at the point of call.
    @headius
    headius committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    1e6829d View commit details
    Browse the repository at this point in the history

  2. Move call info setup closer to handle build 

    Different types of methods will have different mechanisms for
passing the kwargs callInfo along.
* "Generic" handles just using DynamicMethod.call can use the forms
  that take int callInfo. All existing implementations of that set
  the thread-local anyway, but we have at least pushed the flags
  up to this point.
* Jitted Ruby methods do not yet accept callInfo as a paramter so
  all such calls should be wrapped by callInfo thread-local.
* Native core methods do not yet accept callInfo as a parameter so
  all such calls should be wrapped by callInfo thread-local.
* Construction with new/initialize does not yet accept callInfo as
  a parameter so all such calls should be wrapped by callInfo
  thread-local.

I do not believe any other cases being built for indy dispatch
right now end up in core that cares about keywords, so the flags
do not need to be set.
    @headius
    headius committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    4b7eb42 View commit details
    Browse the repository at this point in the history