Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: state_space_cython misc #697

Closed

Conversation

ajgpitch
Copy link
Contributor

add missing colons and fix indentation

@ajgpitch
Copy link
Contributor Author

This fixes #696

@zhenwendai
Copy link
Member

I have fixed the failed test case regarding the new version of matplotlib. @ajgpitch Could you update the branch? It seems that your changes fail on Python 2.7. Could you have a look at it? Thanks.

@ajgpitch
Copy link
Contributor Author

I have merged in the latest devel branch and fixed another typo.
Tests for this may not pass until #693 and #695 are merged.

@ajgpitch
Copy link
Contributor Author

This error in py2 illustrates why #695 is needed and #720 is advisable. The fix was made in state_space_cython.pyx but this had to be manually cythonized. I have done this now and will try another push

@codecov-io
Copy link

codecov-io commented Jan 10, 2019

Codecov Report

Merging #697 into devel will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           devel    #697   +/-   ##
=====================================
  Coverage     54%     54%           
=====================================
  Files        207     207           
  Lines      20955   20955           
  Branches    2818    2818           
=====================================
  Hits       11316   11316           
  Misses      9123    9123           
  Partials     516     516

@ajgpitch
Copy link
Contributor Author

I also notice that there are no Travis tests for Python 3.7

@jbect
Copy link
Contributor

jbect commented May 10, 2020

This PR should be closed, since it has been merged as part of PR #719.

@ekalosak
Copy link
Contributor

Closing due to #697 (comment)
Thank you @jbect and @ajgpitch .

@ekalosak ekalosak closed this Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants