Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Untrack .c files generated by Cython #720

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

ajgpitch
Copy link
Contributor

It is not necessary to store these files in Github. They should be generated locally after a clone.
Tracking them leads to unnecessary commits, such as the last one in #719.

Can also mask issues in underlying .pyx files. I assume this is how the issues fixed in #697 must have made it into the devel branch. Otherwise tests could not have passed.

.c files added to .gitignore
cythonised c files untracked

Any future C files which are not generated by Cython can be added using

git add -f

The two C files that fit that description are not untracked by this PR.

cythonised c files untracked
@ekalosak
Copy link
Contributor

This is great, thanks for improving the code sanitization 🙏
Problem is it's not passing CI (the build expects these .c files).
Once that's fixed, this LGTM, good engineering.

@ekalosak
Copy link
Contributor

The only thing blocking this (otherwise correct) PR is to update the CI so it builds - and therefore doesn't require - the .c files you've removed. It's the right move, just incomplete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants