Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModuleInst.place() does not check for overlap #478

Open
clavin-xlnx opened this issue Jul 19, 2022 · 0 comments
Open

ModuleInst.place() does not check for overlap #478

clavin-xlnx opened this issue Jul 19, 2022 · 0 comments

Comments

@clavin-xlnx
Copy link
Member

#477 has a workaround by adding an overload to place ModuleInst objects without allowing overlapping placement. This should probably be the default behavior. However, the BlockPlacer2 and other code has been working in the opposite sense for some time now. There should be a transition to disallow or make the obvious place() method disallow this by default. One other consideration is that ModuleInst.getAllValidPlacements() uses ModuleInst.place() to identify which locations are valid for placing the module. Usually it does this in a vacuum, but it can also destructively change the Design's set of used SiteInst.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant