Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPI: Adding vpiPort detection (Corrects regression introduced by #753) #762

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kammoh
Copy link
Contributor

@kammoh kammoh commented Feb 22, 2019

  • Feixes regression introduced by VPI: add support for detecting ports and their directions #753
  • Enables vpi_get(vpiType, handle_to_port) to return vpiPort if the signal is a port. It also enables vpi_get(vpiDirection, handle_to_port) to return correct port directions (vpiInput, vpiOutput, or vpiInout).
  • gna/issue450 is modified to look for vpiPorts instead of vpiNets.
  • vpi_user.h is updated to the latest from IEEE Std 1800-2017

@tgingold
Copy link
Member

Could you rebase your branch ? It looks like a new version of the #753 patch rather than changes from it.

I am OK for updating vpi_user.h, but this must be a separate pull request, as this is a large change.

What is different from the #753 change ? In particular how does it fix the cocotb issue ?

@Paebbels Paebbels added this to the v0.36 milestone Feb 23, 2019
@Paebbels Paebbels modified the milestones: v0.36, v0.37 Mar 10, 2019
@eine eine modified the milestones: v0.37, v1.0 May 8, 2020
@umarcor umarcor modified the milestones: v1.0, v2.0 Feb 3, 2021
@umarcor umarcor modified the milestones: v2.0, v3.0 Mar 1, 2022
@umarcor umarcor modified the milestones: v3.0, v4.0 Mar 8, 2023
@gatk555
Copy link

gatk555 commented Apr 9, 2024

I have a potential application that wraps an arbitrary GHDL simulation for co-simulation with SPICE. The first step is to use VPI to discover the ports: vpi_iterate(vpiModule, NULL) and vpi_scan() find the top entity, vpi_iterate(vpiPort, top) returns a handle, but then vpi_scan() yields nothing.

It looks likely to be the same problem described here. Is it worth spending some time to retrieve the associated Pull Request and try and put it into acceptable form? Unfortunately my previous experience with Ada was brief and decades ago ...

Edit: to answer my own question: the relevant part of this merged easily into current master: PR #2648.

gatk555 pushed a commit to gatk555/ghdl that referenced this pull request Apr 15, 2024
…rts3,

the source for PR ghdl#762:
  "VPI: Adding vpiPort detection (Corrects regression introduced by ghdl#753)".
This seems the only part of the PR that addresses the title issue and
even then mostly seems to be an unrelated improvement to vpi_get_string().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants