Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable change price from explorer #7879

Open
exezbcz opened this issue Oct 29, 2023 · 10 comments · May be fixed by #9880
Open

Disable change price from explorer #7879

exezbcz opened this issue Oct 29, 2023 · 10 comments · May be fixed by #9880
Assignees
@iMac7
Labels
A-explorer A-mass-listing bug Something isn't working p2 core functionality, or is affecting 60% of app

Comments

@exezbcz
Copy link
Member

exezbcz commented Oct 29, 2023

image
image
image

  • should stay only on profile
@exezbcz exezbcz added bug Something isn't working p3 non-core, affecting less than 40% A-explorer A-mass-listing labels Oct 29, 2023
@prachi00
Copy link
Member

prachi00 commented Nov 2, 2023

👋

@kodabot
Copy link
Collaborator

kodabot commented Nov 2, 2023

ASSIGNED - @prachi00 🔒 LOCKED -> Friday, November 3rd 2023, 15:19:42 UTC -> 36 hours

prachi00 added a commit to prachi00/nft-gallery that referenced this issue Nov 2, 2023
@prachi00
kodadot#7879 Disable change price from explorer
1c1c011
@prachi00 prachi00 mentioned this issue Nov 2, 2023
Closed
6 tasks
@prachi00 prachi00 removed their assignment Nov 6, 2023
@kodabot
Copy link
Collaborator

kodabot commented Nov 6, 2023

ASSIGNMENT EXPIRED - @prachi00 has been unassigned.

@prachi00
Copy link
Member

prachi00 commented Nov 6, 2023

up for grabs!

@exezbcz exezbcz added p2 core functionality, or is affecting 60% of app and removed p3 non-core, affecting less than 40% labels Nov 6, 2023
@iMac7
Copy link
Contributor

iMac7 commented Mar 25, 2024

@exezbcz should list for sale button be disabled on explorer just like change price in this issue, because both buttons trigger the same modal 🤔

@exezbcz
Copy link
Member Author

exezbcz commented Mar 26, 2024

@iMac7 yes, almost changed my mind that its not needed to be disabled, but since there is also cart function that selects the cards the same way, it could be confusing

should list for sale button be disabled on explorer just like change price in this issue

yes

@iMac7
Copy link
Contributor

iMac7 commented Mar 26, 2024

@exezbcz
Would we then need an alternative way to differentiate between your own nfts and other ones or leave the label?
Keep hover effect or nah?

@exezbcz
Copy link
Member Author

exezbcz commented Mar 26, 2024

@iMac7 just remove the popup: change price, list

@iMac7
Copy link
Contributor

iMac7 commented Mar 26, 2024

👋

@kodabot
Copy link
Collaborator

kodabot commented Mar 26, 2024

ASSIGNED - @iMac7 🔒 LOCKED -> Wednesday, March 27th 2024, 06:02:55 UTC -> 24 hours

@iMac7 iMac7 linked a pull request Mar 26, 2024 that will close this issue
Draft
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iMac7 iMac7

Labels
A-explorer A-mass-listing bug Something isn't working p2 core functionality, or is affecting 60% of app
Projects
None yet
Milestone
No milestone
4 participants
@prachi00 @iMac7 @exezbcz @kodabot