Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clicking followed by should open followers tab #10250

Merged
merged 3 commits into from May 14, 2024

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

test URL path: /ahp/u/1CBmjqJvV1ha8BPQ5JAXGEzeJBLmGHNG9gYg96eC1dnjH5W

@Jarsen136 Jarsen136 requested a review from a team as a code owner May 6, 2024 21:51
@Jarsen136 Jarsen136 requested review from daiagi and hassnian and removed request for a team May 6, 2024 21:51
Copy link

netlify bot commented May 6, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit ba4a221
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6639de005972060008a92bd6
😎 Deploy Preview https://deploy-preview-10250--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@daiagi
Copy link
Contributor

daiagi commented May 6, 2024

@exezbcz

does this means that the users' avatars inside the followers tab should link to their profile?

@exezbcz
Copy link
Member

exezbcz commented May 7, 2024

does this means that the users' avatars inside the followers tab should link to their profile?

can be, but the bold name is enough

as in:

@exezbcz
Copy link
Member

exezbcz commented May 7, 2024

should be the same overlap styling as on canary
image

@Jarsen136
Copy link
Contributor Author

Jarsen136 commented May 7, 2024

should be the same overlap styling as on canary image

✅ Fixed

image

Copy link

codeclimate bot commented May 7, 2024

Code Climate has analyzed commit ba4a221 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@daiagi
Copy link
Contributor

daiagi commented May 7, 2024

but the bold name is enough

Enough for what?
as it is, it is really hard to navigate between profiles

Should be easy to go from 1 profile to the following / followers

@Jarsen136
Copy link
Contributor Author

Jarsen136 commented May 7, 2024

but the bold name is enough

Enough for what? as it is, it is really hard to navigate between profiles

Should be easy to go from 1 profile to the following / followers

As I have implemented on #10196, the profile avatar is clickable and could be navigated to its profile page.

image

@prury
Copy link
Member

prury commented May 7, 2024

what should happen if i click on it with a disconnected account?

Gravacao.de.tela.de.07-05-2024.09.39.59.webm

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label May 7, 2024
@vikiival
Copy link
Member

pay 5 usd

@vikiival vikiival added the paid pull-request has been paid label May 11, 2024
@kodadot kodadot locked as resolved and limited conversation to collaborators May 11, 2024
@vikiival
Copy link
Member

😍 Perfect, I’ve sent the payout
💵 $5 @ 6.73 USD/DOT ~ 0.743 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x839d3fdd897012f14f05ddfb759e4e1a0a75b0ddaccca4d1d29d3fc1abe9fb40
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@prury
Copy link
Member

prury commented May 13, 2024

@hassnian review pls

@hassnian
Copy link
Contributor

@Jarsen136 tabs are not loading

CleanShot.2024-05-14.at.09.44.04.mp4

@Jarsen136
Copy link
Contributor Author

@Jarsen136 tabs are not loading

CleanShot.2024-05-14.at.09.44.04.mp4

It's related to unconnected status and fixed on #10260

@vikiival vikiival added this pull request to the merge queue May 14, 2024
Merged via the queue into kodadot:main with commit 0c3951c May 14, 2024
19 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking followed by should open followers tab
6 participants