Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace icons with uploaded profile picture #10257

Merged
merged 4 commits into from
May 9, 2024

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Feature

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner May 7, 2024 11:05
@Jarsen136 Jarsen136 requested review from daiagi and hassnian and removed request for a team May 7, 2024 11:05
Copy link

netlify bot commented May 7, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit afde25e
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/663cc1ebd8529f0008e673a9
😎 Deploy Preview https://deploy-preview-10257--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prury
Copy link
Member

prury commented May 7, 2024

@Jarsen136 from what i could verify, the test is interrupted because the following error is thrown when accessing a non-new-structured profile:

Error: Failing test due to error in browser: FetchError: [GET] "https://profile-beta.kodadot.workers.dev/profiles/5Evgu7n2pVLkj6QfAdDAx11yqmQKstAJbkPCnscYf9pMxTja": 404

image

is there a way to handle it?

@Jarsen136
Copy link
Contributor Author

Jarsen136 commented May 7, 2024

@Jarsen136 from what i could verify, the test is interrupted because the following error is thrown when accessing a non-new-structured profile:

Error: Failing test due to error in browser: FetchError: [GET] "https://profile-beta.kodadot.workers.dev/profiles/5Evgu7n2pVLkj6QfAdDAx11yqmQKstAJbkPCnscYf9pMxTja": 404

image

is there a way to handle it?

Yup, will fix it

✅ DONE

@prury
Copy link
Member

prury commented May 7, 2024

i think we may improve it a bit and not show the old wallet image when opening the profile, maybe a skeleton? @exezbcz wdyt

Gravacao.de.tela.de.07-05-2024.13.47.48.webm

@exezbcz
Copy link
Member

exezbcz commented May 8, 2024

amazing! Looking fresh

could you also please change the "address" to the offchain name

image

i will make some ux improvements followups to ensure it does not compromise the usability

components/identity/IdentityItem.vue Outdated Show resolved Hide resolved
@exezbcz
Copy link
Member

exezbcz commented May 8, 2024

@prury hmm interesting that its not in the cache?

@Jarsen136
Copy link
Contributor Author

amazing! Looking fresh

could you also please change the "address" to the offchain name

✅ Updated
image

@Jarsen136
Copy link
Contributor Author

Jarsen136 commented May 8, 2024

i think we may improve it a bit and not show the old wallet image when opening the profile, maybe a skeleton? @exezbcz wdyt

@prury hmm interesting that its not in the cache?

I have added a better cache for the profile. Could you please test it again?
Kapture

@prury
Copy link
Member

prury commented May 8, 2024

i think we may improve it a bit and not show the old wallet image when opening the profile, maybe a skeleton? @exezbcz wdyt

@prury hmm interesting that its not in the cache?

I have added a better cache for the profile. Could you please test it again?

much better thank you!

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label May 8, 2024
Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

Co-authored-by: Hassnian <44554284+hassnian@users.noreply.github.com>
Copy link

codeclimate bot commented May 9, 2024

Code Climate has analyzed commit afde25e and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented May 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@prury prury added this pull request to the merge queue May 9, 2024
Merged via the queue into kodadot:main with commit fc9f3d8 May 9, 2024
19 checks passed
This was referenced May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace icons with uploaded profile picture
5 participants