-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Replace icons with uploaded profile picture #10257
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@Jarsen136 from what i could verify, the test is interrupted because the following error is thrown when accessing a non-new-structured profile: Error: Failing test due to error in browser: FetchError: [GET] "https://profile-beta.kodadot.workers.dev/profiles/5Evgu7n2pVLkj6QfAdDAx11yqmQKstAJbkPCnscYf9pMxTja": 404 is there a way to handle it? |
✅ DONE |
i think we may improve it a bit and not show the old wallet image when opening the profile, maybe a skeleton? @exezbcz wdyt Gravacao.de.tela.de.07-05-2024.13.47.48.webm |
@prury hmm interesting that its not in the cache? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
Co-authored-by: Hassnian <44554284+hassnian@users.noreply.github.com>
Code Climate has analyzed commit afde25e and detected 0 issues on this pull request. View more on Code Climate. |
Quality Gate passedIssues Measures |
Thank you for your contribution to the Koda - Generative Art Marketplace.
👇 __ Let's make a quick check before the contribution.
PR Type
Needs Design check
Needs QA check
Context
Did your issue had any of the "$" label on it?
Screenshot 📸