Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

followers modal when disconnected #10260

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

followers modal when disconnected #10260

wants to merge 3 commits into from

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented May 7, 2024 •
edited

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    image

@daiagi daiagi requested a review from a team as a code owner May 7, 2024 13:57
@daiagi daiagi requested review from vikiival and hassnian and removed request for a team May 7, 2024 13:57
@netlify Netlify
Copy link

netlify bot commented May 7, 2024 •
edited

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 216f658
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/663a335c5789780008a378fc
😎 Deploy Preview https://deploy-preview-10260--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codeclimate CodeClimate
Copy link

codeclimate bot commented May 7, 2024

Code Climate has analyzed commit 216f658 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@daiagi daiagi requested review from Jarsen136 and removed request for vikiival May 7, 2024 14:01
@daiagi daiagi changed the title force modal responsivness followers modal when disconnected May 7, 2024
@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels May 7, 2024
@prury
Copy link
Member

prury commented May 7, 2024

issue was updated

@daiagi
Copy link
Contributor Author

daiagi commented May 7, 2024 •
edited

Yep
Will change to conform to requirements

@daiagi daiagi marked this pull request as draft May 7, 2024 17:39
@Jarsen136 Jarsen136 mentioned this pull request May 14, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hassnian hassnian Awaiting requested review from hassnian hassnian is a code owner automatically assigned from kodadot/code-review-guild

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Click on following/followers tab with a disconnected account?
2 participants
@daiagi @prury