-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
silicon: init module #5387
base: master
Are you sure you want to change the base?
silicon: init module #5387
Conversation
Tests fail because it's unable to check the existance of EDIT: do tests run |
# https://github.com/Aloxaf/silicon/issues/242 | ||
home.activation.siliconCache = hm.dag.entryAfter [ "linkGeneration" ] '' | ||
( | ||
export XDG_CACHE_HOME=${escapeShellArg config.xdg.cacheHome} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
settings = mkOption { | ||
type = types.str; | ||
default = ""; | ||
example = literalExpression '' | ||
--shadow-color '#555' | ||
--background '#fff' | ||
--shadow-blur-radius 30 | ||
--no-window-controls | ||
''; | ||
description = '' | ||
Silicon configuration. | ||
''; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I worked on my own module for Silicon, I went with a more true-to-Nix approach and I'd love to hear your thoughts. Settings would be set with Nix values (https://github.com/uncenter/flake/blob/9908d5d4f3e345459dfc638f6434d9d28ec5446b/modules/extra/home-manager/silicon.nix#L11-L23) and this attrset would then be converted into the configuration file with https://github.com/uncenter/flake/blob/9908d5d4f3e345459dfc638f6434d9d28ec5446b/modules/extra/home-manager/silicon.nix#L43-L57. You can see it in action at https://github.com/uncenter/flake/blob/9908d5d4f3e345459dfc638f6434d9d28ec5446b/home/programs/silicon.nix#L6-L10.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also doesn't look like I can reuse https://github.com/sharkdp/bat themes and syntaxes. A configuration option for the directory in which to build the cache would be nice!
Description
Add new module to manage silicon configuration.
Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC