Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google sign-in prompt shows up on some websites #2869

Closed
3 tasks
Swarkin opened this issue May 17, 2024 · 9 comments · Fixed by #2872
Closed
3 tasks

Google sign-in prompt shows up on some websites #2869

Swarkin opened this issue May 17, 2024 · 9 comments · Fixed by #2872
Labels

Comments

@Swarkin
Copy link

Swarkin commented May 17, 2024

OS/Platform

Windows

Installed

https://ungoogled-software.github.io/ungoogled-chromium-binaries/

Version

Version 122.0.6261.94 (Official Build, ungoogled-chromium) (64-bit)

Have you tested that this is not an upstream issue or an issue with your configuration?

  • I have tried reproducing this issue in Chrome and it could not be reproduced there
  • I have tried reproducing this issue in vanilla Chromium and it could not be reproduced there
  • I have tried reproducing this issue in ungoogled-chromium with a new and empty profile using --user-data-dir command line argument and it could not be reproduced there

Description

Google sign-in prompt shows up on some websites.

How to Reproduce?

Go to medium.com
image

Actual behaviour

Google sign-in prompt shows up on some websites.

Expected behaviour

I expected ungoogled-chromium to be ungoogled

Relevant log output

No response

Additional context

Is this left in for a reason? The browser managed to extract my account info from presumably YouTube and now shows it in a small popup when websites support Google sign-in.

@Swarkin Swarkin added the bug label May 17, 2024
@opzch
Copy link

opzch commented May 17, 2024

I don't think this is a part of browser interface. You can block third-party cookies for accounts.google.com to remove your account from this popup. Or use an ad blocking extension to hide this prompt and block third-party requests.

@Swarkin
Copy link
Author

Swarkin commented May 18, 2024

It even shows up when I delete the entire html document:
image
It is a native browser popup

@Swarkin
Copy link
Author

Swarkin commented May 18, 2024

Found the culprit and honestly surprised this isnt off by default or even removed entirely.
WMLSszAkgS

@PF4Public
Copy link
Contributor

@networkException @Ahrotahn Is it worth flipping this setting by default?

@Ahrotahn
Copy link
Contributor

With our changes the identity provider should return that the profile is not signed in. Granted, we should probably add that section to the UI removal patch since it doesn't, or at least shouldn't, do anything.

I tested with my local linux build as well as the windows builds for 122.0.6261.94-1 and 124.0.6367.207-1 from our binaries page and I'm not able to reproduce this.

Are you using a third-party build? Maybe they are not building with our sign-in changes.
Are you using a profile that was used with another browser? Maybe there is a variable that got set in the profile that we didn't expect to be changed.

@Rusenche
Copy link

Rusenche commented May 18, 2024

I tested https://github.com/ungoogled-software/ungoogled-chromium-windows/releases/tag/124.0.6367.207-1.1 - ungoogled-chromium_124.0.6367.207-1.1_windows_x64.zip (@teeminus) (only default settings, no extensions installed, absolutely clean)

and indeed it turns out that the default setting is not what it should be:

sssssss

sssssss 1

I confirm @Swarkin's point.

@Ahrotahn
Copy link
Contributor

@Rusenche The interface option for the setting existing wasn't in question. Can you reproduce the Google sign-in dialog this issue is about?

@Swarkin
Copy link
Author

Swarkin commented May 18, 2024

@Ahrotahn

Are you using a third-party build? Maybe they are not building with our sign-in changes.

I am using the windows build from the builds website linked in the readme on version 122 as that is the last version without the UI refresh.

Are you using a profile that was used with another browser?

I only imported a bookmark html file and the browser was one of the first things I installed on a fresh windows ltsc install, so no other browsers were present.

@Ahrotahn
Copy link
Contributor

I'll see what I can figure out. It might be better to remove fedcm functionality alltogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants