routing: clean-up & fix blinded path incoming chained channel logic #9925

ellemouton · 2025-06-10T12:59:30Z

As promised in review of this PR, this PR addresses the remaining
comments I had. It also fixes a bug that was introduced in that PR. See commit messages for details.

coderabbitai · 2025-06-10T12:59:37Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

ellemouton · 2025-06-10T13:53:26Z

cc @MPins

MPins

Nice improvement! 👍

routing/pathfind_test.go

itest/lnd_route_blinding_test.go

routing/pathfind_test.go

bitromortac

LGTM, nice fix 🎉 (just have a question)

routing/pathfind.go

bitromortac · 2025-06-16T08:30:18Z

routing/pathfind_test.go

+		if _, ok := channelIDs[node1Vertex]; !ok {
+			channelIDs[node1Vertex] = map[route.Vertex]uint64{}
+		}
+		channelIDs[node1Vertex][node2Vertex] = channelID
+
+		if _, ok := channelIDs[node2Vertex]; !ok {
+			channelIDs[node2Vertex] = map[route.Vertex]uint64{}
+		}
+		channelIDs[node2Vertex][node1Vertex] = channelID


nit: this could be error-prone if parallel channels were added

indeed - note, however, that this is using a pre-existing map. So i think it's fine for now since this isnt introducing a new helper, it just ensures that the existing helper is populated properly.

If we run into an issue in future, we can update the helper

ziggie1984

Nice improvements 🫡, have two open questions.

routing/pathfind.go

itest/lnd_route_blinding_test.go

lightninglabs-deploy · 2025-06-24T11:39:43Z

@ellemouton, remember to re-request review from reviewers when ready

Here we add some more comments and a bit of code clean up to the `findBlindedPaths` function. No logic is changed here.

Add a helper so that we can refer to channels by using the aliases of the nodes that own the channel instead of needing to use the raw channel ID.

This is just in preparation for the next commit. The test will be cleaned up more after a bug is fixed.

Improve the readability of the existing test.

Here we fix a bug which would not include the selected incoming blinded path chain from being included in the selected path set if it meets the minimum length requirement. The appropriate unit test and itest is updated to demonstrate the fix.

Cover more cases for the incoming chained channel feature.

ziggie1984

LGTM 🧹

itest/lnd_route_blinding_test.go

routing/pathfind.go

ellemouton added this to the v0.20.0 milestone Jun 10, 2025

ellemouton self-assigned this Jun 10, 2025

ellemouton added the blinded paths label Jun 10, 2025

ellemouton force-pushed the rbIncomingFollowup branch 2 times, most recently from ffde0e1 to 371d45c Compare June 10, 2025 13:53

ellemouton requested a review from ziggie1984 June 10, 2025 13:53

saubyk requested a review from bitromortac June 10, 2025 16:44

MPins reviewed Jun 11, 2025

View reviewed changes

routing/pathfind_test.go Outdated Show resolved Hide resolved

itest/lnd_route_blinding_test.go Outdated Show resolved Hide resolved

routing/pathfind_test.go Outdated Show resolved Hide resolved

bitromortac approved these changes Jun 16, 2025

View reviewed changes

ziggie1984 reviewed Jun 17, 2025

View reviewed changes

routing/pathfind.go Show resolved Hide resolved

routing/pathfind.go Show resolved Hide resolved

itest/lnd_route_blinding_test.go Show resolved Hide resolved

ellemouton added 8 commits June 25, 2025 12:33

routing: add comments and clean-up to findBlindedPaths

da37fe2

Here we add some more comments and a bit of code clean up to the `findBlindedPaths` function. No logic is changed here.

routing: improve TestFindBlindedPaths readability

4bc0aee

Add a helper so that we can refer to channels by using the aliases of the nodes that own the channel instead of needing to use the raw channel ID.

routing: clean-up the tests a bit

067e316

This is just in preparation for the next commit. The test will be cleaned up more after a bug is fixed.

itest: clean-up partially specified blinded path test

51f1932

Improve the readability of the existing test.

routing: expand routeblinding path finding tests

4945bd4

Cover more cases for the incoming chained channel feature.

routing: fix log line formatting

6475787

docs: update release notes

a4459cc

ellemouton force-pushed the rbIncomingFollowup branch from 371d45c to a4459cc Compare June 25, 2025 10:57

ellemouton requested a review from ziggie1984 June 25, 2025 10:57

ziggie1984 approved these changes Jun 25, 2025

View reviewed changes

itest/lnd_route_blinding_test.go Show resolved Hide resolved

routing/pathfind.go Show resolved Hide resolved

ellemouton merged commit 1fcf112 into lightningnetwork:master Jun 25, 2025
32 of 33 checks passed

ellemouton deleted the rbIncomingFollowup branch June 25, 2025 14:30

routing: clean-up & fix blinded path incoming chained channel logic #9925

routing: clean-up & fix blinded path incoming chained channel logic #9925

Uh oh!

Conversation

ellemouton commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jun 10, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

ellemouton commented Jun 10, 2025

Uh oh!

MPins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bitromortac left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bitromortac Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

ellemouton Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

ziggie1984 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lightninglabs-deploy commented Jun 24, 2025

Uh oh!

ziggie1984 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ellemouton commented Jun 10, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)