Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*) switch to a Kuma fork of go-control-plane #2771

Merged
merged 1 commit into from
Sep 14, 2021
Merged

fix(*) switch to a Kuma fork of go-control-plane #2771

merged 1 commit into from
Sep 14, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Sep 14, 2021

Summary

Switch to a Kuma fork of go-control-plane so that the project has better
control over the stability of releases, and can cherry-pick individual
fixes.

The fork branch is the same revision of go-control-plane that we were already using, with the additional cherry-pick of envoyproxy/go-control-plane#430.

Ref #2004

Full changelog

  • Picked up an Envoy control plane fix that can cause kuma-cp to leak goroutines.

Issues resolved

N/A

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Switch to a Kuma fork of go-control-plane so that the project has better
control over the stability of releases, and can cherry-pick individual
fixes.

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach requested a review from a team as a code owner September 14, 2021 00:51
@codecov-commenter
Copy link

Codecov Report

Merging #2771 (c08abdf) into master (336d724) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2771      +/-   ##
==========================================
- Coverage   51.96%   51.96%   -0.01%     
==========================================
  Files         877      877              
  Lines       51173    51173              
==========================================
- Hits        26591    26590       -1     
- Misses      22467    22469       +2     
+ Partials     2115     2114       -1     
Impacted Files Coverage Δ
pkg/insights/components.go 70.00% <0.00%> (-30.00%) ⬇️
.../core/managers/apis/ratelimit/ratelimit_manager.go 35.48% <0.00%> (-9.68%) ⬇️
pkg/insights/resyncer.go 65.67% <0.00%> (-1.50%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 83.90% <0.00%> (+1.14%) ⬆️
pkg/core/resources/manager/cache.go 81.81% <0.00%> (+2.59%) ⬆️
pkg/core/bootstrap/autoconfig.go 54.46% <0.00%> (+8.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 336d724...c08abdf. Read the comment docs.

@jakubdyszkiewicz jakubdyszkiewicz merged commit 13a2ffa into kumahq:master Sep 14, 2021
mergify bot pushed a commit that referenced this pull request Sep 14, 2021
Switch to a Kuma fork of go-control-plane so that the project has better
control over the stability of releases, and can cherry-pick individual
fixes.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit 13a2ffa)
jakubdyszkiewicz pushed a commit that referenced this pull request Sep 14, 2021
Switch to a Kuma fork of go-control-plane so that the project has better
control over the stability of releases, and can cherry-pick individual
fixes.

Signed-off-by: James Peach <james.peach@konghq.com>
nikita15p pushed a commit to nikita15p/kuma that referenced this pull request Sep 28, 2021
Switch to a Kuma fork of go-control-plane so that the project has better
control over the stability of releases, and can cherry-pick individual
fixes.

Signed-off-by: James Peach <james.peach@konghq.com>
nikita15p pushed a commit to nikita15p/kuma that referenced this pull request Sep 28, 2021
Switch to a Kuma fork of go-control-plane so that the project has better
control over the stability of releases, and can cherry-pick individual
fixes.

Signed-off-by: James Peach <james.peach@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants