-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement date functions #85
Conversation
I wanted to do the similar for The other date functions (i.e. strftime/strptime) don't have equivalents in the time crate. Could maybe use https://github.com/MiSawa/time-fmt/ |
To help you with this, would you like to elaborate how you were trying to approach the problem?
I'd say let's go for now only for the ISO format, and postpone the hard case if there is sufficient demand later. :) |
I don't remember exactly what I did, but it was pretty involved. Looking at it with fresh eyes, the problem seems a lot simpler. 😅 I added the new implementation in 7bc1b54. tell me what you think |
Looks like tests are failing because I added Lines 12 to 21 in 5184281
Should I just add |
You can go ahead and make |
That looks nice now that the functions round-trip. |
Just now realized that |
Don't worry about |
Implement date functions:
now
fromdateiso8601
todateiso8601