You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The EncoderDecoder.Config methods for pre-calculating the encoded and decoded out size should accept a Long instead of Int, and return a Long
decodeOutMaxSizeOrFail should accept null for input to be usable with streams.
3. A stream won't have access to the entirety of what is being decoded and thus, cannot send DecoderInput.
DecoderInput should check for a negative return value of decodeOutMaxSizeOrFail and throw EncodingException
DecoderInput should check if the returned Long is greater than Int.MAX_VALUE and throw EncodingException
There's a possibility of the EncoderDecoder.Config implementation having an overflow issue, that should be checked for in the base abstraction and throw such that we can guarantee a positive value is always returned.
The text was updated successfully, but these errors were encountered:
The encodeOutSize and decodeOutMaxSizeOrFail methods should throw some sort of overflow exception if the number is greater than Long.MAX_VALUE. Think a new exception here that inherits from EncodingException would be best, in order to be specific.
EncoderDecoder.Config
methods for pre-calculating the encoded and decoded out size should accept aLong
instead ofInt
, and return aLong
decodeOutMaxSizeOrFail
should acceptnull
forinput
to be usable with streams.3. A stream won't have access to the entirety of what is being decoded and thus, cannot send
DecoderInput
.DecoderInput
should check for a negative return value ofdecodeOutMaxSizeOrFail
and throwEncodingException
DecoderInput
should check if the returnedLong
is greater thanInt.MAX_VALUE
and throwEncodingException
There's a possibility of the
EncoderDecoder.Config
implementation having an overflow issue, that should be checked for in the base abstraction and throw such that we can guarantee a positive value is always returned.The text was updated successfully, but these errors were encountered: