Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change EncoderDecoder pre-calculation input/output types to Long #52

Merged
merged 10 commits into from
Jan 20, 2023

Conversation

05nelsonm
Copy link
Owner

@05nelsonm 05nelsonm commented Jan 20, 2023

Closes #48

This PR:

  • Updates the input/output number types for EncoderDecoder pre-calculation methods from Int to Long
    • May be used when streaming data, not just decoding an Array or String which is limited to Int.MAX_VALUE
  • Puts up guards in the base abstraction EncoderDecoder.Config so that only positive values are:
    • Passed to the implementations
    • Returned by the implementations
    • Will otherwise throw an EncodingSizeException
  • Adds unit tests for most things in the encoding-core module
    • Don't think it will change very much anymore, so.
  • Fixes the Base32.Crockford.Config calculation when hyphenInterval is set to something.
    • Actual tests for this will come later when implemented; things might move around still, so.
  • Cleans up some documentation
  • Cleans up some code

@05nelsonm 05nelsonm self-assigned this Jan 20, 2023
Copy link
Owner Author

@05nelsonm 05nelsonm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@05nelsonm 05nelsonm merged commit 2a4dcb8 into master Jan 20, 2023
@05nelsonm 05nelsonm deleted the issue/48-encode-decode-out-calculations branch January 20, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix encode/decode out calculations
1 participant