Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stub in Base32 migration to EncoderDecoder #49

Merged
merged 15 commits into from
Jan 20, 2023
Merged

Stub in Base32 migration to EncoderDecoder #49

merged 15 commits into from
Jan 20, 2023

Conversation

05nelsonm
Copy link
Owner

@05nelsonm 05nelsonm commented Jan 20, 2023 •
edited
Loading

Part 1 of #41

Wanted a "check point" here, as before continuing with the actual encoding/decoding implementation, #48 needs to be taken care of.

This PR:

  • Stubs in the implementation for Base32 encoding
  • Reworks the builder patter for Base16
    • Found that when stubbing in things for the Base32 implementation, some things were off
      and to remain consistent across modules, needed to update it.
  • Renames EncoderDecoder.Configuration -> EncoderDecoder.Config
  • Cleans up documentation & code

@05nelsonm
Fix typo
58e3d48
@05nelsonm
Rework builders and config in order to make it so that modifications …
8abcc74 
…can be had without breaking the API
@05nelsonm
Ensure only positive, non-zero numbers are sent to Configuration impl…
55c7a3e 
…ementations
@05nelsonm
Make Base16.Configuration constructor private to inhibit java consume…
af729f6 
…rs from violating desires to push everything through builder pattern
@05nelsonm
Stub in Base32 implementation
9b5220d
@05nelsonm
Ensure that only numbers greater than 0 are sent to encodeOutMaxSizeO…
11224e5 
…rFail
@05nelsonm
Implement decodeOutMaxSizeOrFail
1f4c983
@05nelsonm
Correct documentation
98c5eab
@05nelsonm
Clean up things for Java consumers
8e7c77d
@05nelsonm
Rename EncoderDecoder.Configuration to Config
060b83f
@05nelsonm
Use maths to calculate hyphen count
855c5ed
@05nelsonm
Add setting for Crockford to encode to lowercase
15177e7
@05nelsonm
Add the strict shortcut to builders
611ae6a
@05nelsonm 05nelsonm self-assigned this Jan 20, 2023
05nelsonm
05nelsonm commented Jan 20, 2023
View reviewed changes
Copy link
Owner Author

@05nelsonm 05nelsonm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

library/encoding-base32/src/commonMain/kotlin/io/matthewnelson/encoding/base32/Base32.kt Show resolved Hide resolved
library/encoding-base32/src/commonMain/kotlin/io/matthewnelson/encoding/builders/Base32.kt Show resolved Hide resolved
05nelsonm
05nelsonm commented Jan 20, 2023
View reviewed changes
Copy link
Owner Author

@05nelsonm 05nelsonm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@05nelsonm 05nelsonm merged commit 59de16d into master Jan 20, 2023
@05nelsonm 05nelsonm deleted the issue/41-base32-migration-stub branch January 20, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@05nelsonm 05nelsonm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@05nelsonm