-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Base32
decoding for new EncoderDecoder
#55
Conversation
… other implementations
…oding (to not send padding unnecessarily)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in 2 or so refactors and adding tests, this will be pretty solid implementation. After adding the BitBuffer
abstraction, it is really simple to create encoders.
I think though there can be more things shifted to encoding-core
, like skipping over new lines/spaces, or handling padding. Those 2 things are expressed in the base configuration and should be used to mitigate duplicate, unnecessary code.
Resolved in commit 52f426b 💪 |
Part 2 of #41
This PR:
Crockford
,RFC 4648 section 6
,RFC 4648 section 7
) using the newEncoderDecoder
EncoderDecoder
forBase32
.Base32
).Decoder
extension functions where padding was being sent unnecessarily.