Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate encoding-base32 to use encoding-core #41

Closed
05nelsonm opened this issue Jan 18, 2023 · 2 comments · Fixed by #60
Closed

Migrate encoding-base32 to use encoding-core #41

05nelsonm opened this issue Jan 18, 2023 · 2 comments · Fixed by #60
Labels
enhancement New feature or request

Comments

@05nelsonm
Copy link
Owner

05nelsonm commented Jan 18, 2023

Part 4 of #36

Migrate the base32 module to utilize the encoding-core module. This is an opportunity to write the Base16 Decoder/Encoder in package io.matthewnelson.encoding.base32 and remove component, then have all the current method bodies simply use it as to not disturb the current APIs and remain backwards compatible.

Related to #29

@05nelsonm 05nelsonm added the enhancement New feature or request label Jan 18, 2023
@05nelsonm
Copy link
Owner Author

Note: don't touch current base32 tests. This should serve as a check that the old code is functioning as expected even though the implementation was swapped out.

@05nelsonm
Copy link
Owner Author

Need to remember to clean up the old code and use top level values for Base32.Default and Base32.Hex instead of re-creating them every time the old extension functions are called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant