Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds x-cache headers for hit/miss info, lots o bug fixes #11

Merged
merged 16 commits into from
Feb 10, 2022
Merged

Adds x-cache headers for hit/miss info, lots o bug fixes #11

merged 16 commits into from
Feb 10, 2022

Conversation

06chaynes
Copy link
Owner

  • Adds x-cache and x-cache-lookup headers for cache hit/miss info
  • Forces request method to uppercase in cache keys (breaking change)
  • Extends several existing tests and adds new tests to help verify functionality
  • Fixes issues when a conditional response has a 200 status, including updated response on revalidation and a response with a no-cache directive for example
  • Fixes issue related to deleting an existing cache record on a non GET/HEAD method request to a previously cached resource

@06chaynes
added basic x-cache and x-cache-lookup custom headers logic
829a987
@06chaynes
made x-cache headers lowercase, started adding tests
dce82a1
@06chaynes
added more tests, fixed x-cache header logic for NoCache mode
8786568
@06chaynes
forcing uppercase on method string used in cache key, fixed logic to …
a74b93f 
…delete the cache record when a request is made to the same resource that was not using the GET or HEAD method (required forcing case on method to properly build key), added test to verify the cache record gets deleted in this situation
@06chaynes
added revaliation request test with 304 response
668e42b
@06chaynes
added fix for when the conditional response is a 200, which was causi…
5a2cd6f 
…ng responses with no-cache to return the cache response rather than the conditional response. added check for existing record before delete attempt in case the manager implementation returns an Err on attempt to delete a non-existent record
@06chaynes
rather than doing a get then delete decided to just attempt the delet…
788b620 
…e and ignore any errors (yee haw)
@06chaynes
tweaking the header logic more, also extended some of the existing te…
caf3c87 
…sts with more header checks
@06chaynes
removed some unnecessary clones
fa65934
@06chaynes
ok then, let's get tedious with some testing. should be helpful though
c1d1238
@06chaynes
considering forcing the method to uppercase in cache key a breaking c…
383b4fa 
…hange, plus new header feature, version bumps for everyone
@06chaynes
fixed setting x-cache hit on 304 in conditional response and x-cache …
bf8ca63 
…miss on 200, fixed the 304 test as it should return a HIT for x-cache
@06chaynes
moved the conditional checking for a 200 status of conditional respon…
dd3c5f5 
…se to it's own block, now returning the conditional response and generating a new policy based on that response before caching the updated data, added corresponding test because I sure do like my tests mmmhhhhmm
@06chaynes
moved setting the headers to before the cache gets updated so the cac…
5e1d452 
…hed record matches the given response
@06chaynes
removed use of let in header portion of tests
6c52d07
@06chaynes
added revalidation 500 response test
76b37f2
@06chaynes 06chaynes merged commit cb1c153 into latest Feb 10, 2022
@06chaynes 06chaynes mentioned this pull request Feb 10, 2022
Closed
@06chaynes 06chaynes deleted the x-cache-headers branch February 10, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@06chaynes