Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventsDB: New Rewards Table #1175

Merged
merged 1 commit into from
May 7, 2022
Merged

EventsDB: New Rewards Table #1175

merged 1 commit into from
May 7, 2022

Conversation

iamrz1
Copy link
Contributor

@iamrz1 iamrz1 commented Apr 15, 2022

Changes

Fixes

#912

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2022

Codecov Report

Merging #1175 (7179c55) into staging (d559d33) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           staging    #1175      +/-   ##
===========================================
- Coverage    30.27%   30.23%   -0.05%     
===========================================
  Files          361      363       +2     
  Lines        57709    57783      +74     
===========================================
- Hits         17471    17469       -2     
- Misses       38129    38204      +75     
- Partials      2109     2110       +1     
Flag Coverage Δ
Unit-Tests 30.23% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/go/0chain.net/smartcontract/dbs/event/eventdb.go 14.28% <0.00%> (-0.43%) ⬇️
...e/go/0chain.net/smartcontract/dbs/event/process.go 0.00% <0.00%> (ø)
...de/go/0chain.net/smartcontract/dbs/event/reward.go 0.00% <0.00%> (ø)
...hain.net/smartcontract/storagesc/collect_reward.go 0.00% <0.00%> (ø)
.../smartcontract/storagesc/collect_reward_eventdb.go 0.00% <0.00%> (ø)
...ain.net/smartcontract/storagesc/config_settigns.go 33.47% <0.00%> (-0.15%) ⬇️
...e/go/0chain.net/smartcontract/storagesc/handler.go 0.00% <0.00%> (ø)
code/go/0chain.net/smartcontract/storagesc/sc.go 7.69% <0.00%> (-0.07%) ⬇️
code/go/0chain.net/chaincore/node/n2n_send.go 31.68% <0.00%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d559d33...7179c55. Read the comment docs.

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 9cd5385 into staging May 7, 2022
@iamrz1 iamrz1 deleted the feat/reward_table branch May 7, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants