Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User node fix #1347

Merged
merged 4 commits into from
Jun 13, 2022
Merged

User node fix #1347

merged 4 commits into from
Jun 13, 2022

Conversation

Dmdv
Copy link
Contributor

@Dmdv Dmdv commented Jun 6, 2022

Fixes

#1346

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@Dmdv Dmdv requested a review from dabasov June 6, 2022 00:07
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2022

Codecov Report

Merging #1347 (204b4cf) into staging (aa3e028) will decrease coverage by 0.01%.
The diff coverage is 42.42%.

@@             Coverage Diff             @@
##           staging    #1347      +/-   ##
===========================================
- Coverage    29.83%   29.81%   -0.02%     
===========================================
  Files          357      357              
  Lines        58619    58607      -12     
===========================================
- Hits         17487    17474      -13     
- Misses       39182    39183       +1     
  Partials      1950     1950              
Flag Coverage Δ
Unit-Tests 29.81% <42.42%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...de/go/0chain.net/smartcontract/zcnsc/authorizer.go 30.14% <ø> (ø)
code/go/0chain.net/smartcontract/zcnsc/mint.go 40.00% <0.00%> (+1.90%) ⬆️
.../go/0chain.net/smartcontract/zcnsc/nodes_reader.go 68.57% <60.00%> (-2.40%) ⬇️
code/go/0chain.net/smartcontract/zcnsc/burn.go 58.75% <61.11%> (-2.17%) ⬇️
code/go/0chain.net/core/datastore/worker.go 97.26% <0.00%> (-2.74%) ⬇️
...de/go/0chain.net/smartcontract/vestingsc/config.go 51.57% <0.00%> (-1.58%) ⬇️
code/go/0chain.net/chaincore/node/n2n_send.go 31.68% <0.00%> (-0.45%) ⬇️
...ain.net/smartcontract/storagesc/config_settigns.go 33.81% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa3e028...204b4cf. Read the comment docs.

@Dmdv Dmdv self-assigned this Jun 6, 2022
code/go/0chain.net/smartcontract/zcnsc/burn.go Outdated Show resolved Hide resolved
code/go/0chain.net/smartcontract/zcnsc/burn.go Outdated Show resolved Hide resolved
code/go/0chain.net/smartcontract/zcnsc/burn.go Outdated Show resolved Hide resolved
@Dmdv Dmdv requested a review from ssardana08 June 7, 2022 15:34
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

* staging: (176 commits)
  Update build-&-publish-docker-image.yml
  Make UpdateDKGMinerList private
  added nonce validations
  fixed time loading
  fixed time loading added reference to benchmarks readme
  .
  .
  revert cost safeguard
  fix(git): reverted gitignore
  fixed panic in benchmark_setup.go
  space
  review issues
  total-blobber-capacity
  unit test + lint
  BlobberAverageWritePrice
  Fix log
  Fix unit tests
  BlobberAverageWritePrice
  Added new simplified read-pool
  fix(devops): setup go on github jobs
  ...
@dabasov dabasov self-requested a review June 13, 2022 09:47
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov dabasov merged commit 8d7b110 into staging Jun 13, 2022
@Dmdv Dmdv deleted the user_node_fix branch June 14, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants