Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

currency.Coin extension #1351

Merged
merged 13 commits into from
Jun 13, 2022
Merged

currency.Coin extension #1351

merged 13 commits into from
Jun 13, 2022

Conversation

ssardana08
Copy link
Contributor

@ssardana08 ssardana08 commented Jun 6, 2022

Fixes

  • txn Value converted to currency.Coin
  • txn Fees converted to currency.Coin
  • delegatepool fees, rewards changed to currency.coin
  • stakepool fees, rewards changed to currency.coin

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@ssardana08 ssardana08 marked this pull request as ready for review June 7, 2022 12:42
@ssardana08 ssardana08 added the do not merge Do not merge PR label Jun 7, 2022
@ssardana08 ssardana08 linked an issue Jun 7, 2022 that may be closed by this pull request
7 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2022

Codecov Report

Merging #1351 (6358f3a) into staging (8e107fc) will decrease coverage by 0.00%.
The diff coverage is 25.58%.

@@             Coverage Diff             @@
##           staging    #1351      +/-   ##
===========================================
- Coverage    29.82%   29.81%   -0.01%     
===========================================
  Files          357      357              
  Lines        58619    58720     +101     
===========================================
+ Hits         17481    17506      +25     
- Misses       39186    39236      +50     
- Partials      1952     1978      +26     
Flag Coverage Δ
Unit-Tests 29.81% <25.58%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
code/go/0chain.net/chaincore/chain/entity.go 11.90% <ø> (ø)
...de/go/0chain.net/chaincore/chain/protocol_block.go 0.00% <0.00%> (ø)
.../0chain.net/chaincore/chain/protocol_lfb_ticket.go 9.39% <0.00%> (ø)
code/go/0chain.net/chaincore/chain/state.go 0.41% <0.00%> (+<0.01%) ⬆️
code/go/0chain.net/chaincore/transaction/entity.go 0.71% <0.00%> (+0.02%) ⬆️
...ore/transaction/transaction_confirmation_entity.go 0.00% <0.00%> (ø)
...haincore/transaction/transaction_summary_entity.go 0.00% <0.00%> (ø)
code/go/0chain.net/core/datastore/entity.go 100.00% <ø> (ø)
...e/go/0chain.net/smartcontract/dbs/event/blobber.go 0.00% <ø> (ø)
...chain.net/smartcontract/dbs/event/delegate_pool.go 0.00% <0.00%> (ø)
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e107fc...6358f3a. Read the comment docs.

@ssardana08 ssardana08 removed the do not merge Do not merge PR label Jun 9, 2022
@ssardana08 ssardana08 changed the title Issue 1306 currency.Coin extension Jun 9, 2022
@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests 0chain_issue_1306
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain issue_1306
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@ssardana08 ssardana08 requested a review from peterlimg June 9, 2022 16:05
- configimpl fixed
@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests 0chain_issue_1306
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain issue_1306
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests test-min-submit-100
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain issue_1306
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ssardana08 ssardana08 merged commit ccb942a into staging Jun 13, 2022
@ssardana08 ssardana08 deleted the issue_1306 branch June 13, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change following to currency.Coin
4 participants