Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/nft allocation #1453

Merged
merged 4 commits into from
Jul 31, 2022
Merged

Update/nft allocation #1453

merged 4 commits into from
Jul 31, 2022

Conversation

lawRathod
Copy link
Contributor

Fixes

Changes

closes #828

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2022

Codecov Report

Merging #1453 (488e8b6) into staging (ce69b9b) will decrease coverage by 0.02%.
The diff coverage is 54.83%.

@@             Coverage Diff             @@
##           staging    #1453      +/-   ##
===========================================
- Coverage    29.02%   29.00%   -0.03%     
===========================================
  Files          357      357              
  Lines        57733    57761      +28     
===========================================
- Hits         16759    16752       -7     
- Misses       39134    39171      +37     
+ Partials      1840     1838       -2     
Flag Coverage Δ
Unit-Tests 29.00% <54.83%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...de/go/0chain.net/smartcontract/storagesc/models.go 61.17% <ø> (ø)
...o/0chain.net/smartcontract/storagesc/allocation.go 53.70% <40.00%> (-2.56%) ⬇️
...o/0chain.net/smartcontract/storagesc/models_gen.go 36.96% <61.90%> (+0.12%) ⬆️
...ain.net/smartcontract/storagesc/config_settigns.go 32.50% <0.00%> (ø)
...de/go/0chain.net/smartcontract/vestingsc/config.go 56.31% <0.00%> (+3.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@lawRathod lawRathod self-assigned this Jul 6, 2022
@lawRathod lawRathod requested a review from peterlimg July 7, 2022 15:43
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ssardana08 ssardana08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm..
please fix system tests failure to merge

@lawRathod lawRathod marked this pull request as draft July 29, 2022 07:30
@lawRathod lawRathod force-pushed the update/nftAllocation branch 2 times, most recently from 488e8b6 to d5c0ea2 Compare July 29, 2022 11:51
@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests update/nftRestrictions
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain update/nftAllocation
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests update/nftRestrictions
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain update/nftAllocation
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@dabasov dabasov marked this pull request as ready for review July 31, 2022 09:54
@dabasov dabasov merged commit 6d4ba02 into staging Jul 31, 2022
@service-0chain
Copy link
Collaborator

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NFT: restrict file access options.
6 participants