Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronized access to balances.tree to avoid concurrent read/write #1691

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Synchronized access to balances.tree to avoid concurrent read/write #1691

merged 1 commit into from
Sep 22, 2022

Conversation

manasnisar
Copy link
Contributor

Fixes

Changes

  • Synchronized access to balances.tree to avoid concurrent read/write

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

peterlimg
peterlimg approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/1539
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli staging
0chain fix/1539
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@manasnisar
Copy link
Contributor Author

@dabasov @peterlimg Everything looks good. Please merge when you see fit.

@dabasov dabasov merged commit 760b0f0 into staging Sep 22, 2022
@peterlimg peterlimg deleted the fix/1539 branch December 3, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterlimg peterlimg peterlimg approved these changes

@dabasov dabasov Awaiting requested review from dabasov dabasov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manasnisar @service-0chain @peterlimg @dabasov