Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed unstaking aggregate update #1918

Merged
merged 6 commits into from
Dec 26, 2022
Merged

fixed unstaking aggregate update #1918

merged 6 commits into from
Dec 26, 2022

Conversation

dabasov
Copy link
Member

@dabasov dabasov commented Dec 20, 2022

Fixes

Changes

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@dabasov dabasov changed the title added logging fixed unstaking aggregate update Dec 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Merging #1918 (fc49b79) into staging (6d3131f) will decrease coverage by 0.05%.
The diff coverage is 7.00%.

@@             Coverage Diff             @@
##           staging    #1918      +/-   ##
===========================================
- Coverage    26.58%   26.52%   -0.06%     
===========================================
  Files          358      358              
  Lines        60044    60140      +96     
===========================================
- Hits         15961    15954       -7     
- Misses       42184    42296     +112     
+ Partials      1899     1890       -9     
Flag Coverage Δ
Unit-Tests 26.52% <7.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...o/0chain.net/smartcontract/dbs/event/authorizer.go 0.00% <0.00%> (ø)
...e/go/0chain.net/smartcontract/dbs/event/blobber.go 1.53% <0.00%> (-0.09%) ⬇️
...chain.net/smartcontract/dbs/event/delegate_pool.go 0.00% <0.00%> (ø)
...ode/go/0chain.net/smartcontract/dbs/event/miner.go 0.00% <0.00%> (ø)
...e/go/0chain.net/smartcontract/dbs/event/process.go 1.70% <0.00%> (-0.10%) ⬇️
...e/go/0chain.net/smartcontract/dbs/event/sharder.go 0.00% <0.00%> (ø)
...go/0chain.net/smartcontract/dbs/event/validator.go 0.00% <0.00%> (ø)
code/go/0chain.net/smartcontract/minersc/miner.go 2.11% <0.00%> (ø)
code/go/0chain.net/smartcontract/stakepool/lock.go 0.00% <0.00%> (ø)
...go/0chain.net/smartcontract/stakepool/stakepool.go 12.68% <0.00%> (+0.21%) ⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

code/go/0chain.net/smartcontract/stakepool/unlock.go Outdated Show resolved Hide resolved
@dabasov dabasov merged commit b5ff530 into staging Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants