Challenge complete

[Hitenjain14]

Changes

Moved latestCompletedChallTime from challengeAllocBlobberPassResult to BlobberAllocation , #2160

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

• Ensure system tests are passing. If not Run them manually to check for any regressions 📋
• Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
• Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

• blobber:
• gosdk:
• system_test:
• zboxcli:
• zwalletcli:
• Other: ...

[codecov-commenter]

Codecov Report

Merging #2171 (7ee5212) into staging (816f076) will increase coverage by 0.01%.
The diff coverage is 65.21%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           staging    #2171      +/-   ##
===========================================
+ Coverage    27.10%   27.12%   +0.01%     
===========================================
  Files          374      374              
  Lines        61993    62005      +12     
===========================================
+ Hits         16805    16818      +13     
+ Misses       43200    43192       -8     
- Partials      1988     1995       +7     

Flag	Coverage Δ
Unit-Tests	27.12% <65.21%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...de/go/0chain.net/smartcontract/storagesc/models.go	53.20% <ø> (ø)
...o/0chain.net/smartcontract/storagesc/models_gen.go	35.68% <46.66%> (-0.02%)	⬇️
...go/0chain.net/smartcontract/storagesc/challenge.go	37.50% <100.00%> (ø)
code/go/0chain.net/chaincore/node/n2n_send.go	31.68% <0.00%> (-0.45%)	⬇️
...ain.net/smartcontract/storagesc/config_settigns.go	54.76% <0.00%> (ø)
code/go/0chain.net/core/datastore/worker.go	100.00% <0.00%> (+2.73%)	⬆️
...de/go/0chain.net/smartcontract/vestingsc/config.go	53.68% <0.00%> (+4.73%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[peterlimg]

The allocChallenges.LatestCompletedChallenge need to be replaced with the allocBlob's LatestCompletedChallenge, we can even remove it if it's not being used. See code here. The reason for adding the latest completed challenge to allocBlob is to replace the allocChallenges.LatestCompletedChallenge, otherwise we will cause other bugs. Anyway, I'll do some commits to close this PR ASAP.

[peterlimg]

LGTM

[service-0chain]

Manual system tests [failure] with the following config

config	value
tests skipped	FALSE
system-tests	master
gosdk	NOT OVERRIDDEN
zboxcli	staging
zwalletcli	fix-rounding-off-for-balance
0chain	staging
blobber	staging
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging

[service-0chain]

Manual system tests [failure] with the following config

config	value
tests skipped	FALSE
system-tests	skip-bucket-test
gosdk	NOT OVERRIDDEN
zboxcli	staging
zwalletcli	fix-rounding-off-for-balance
0chain	staging
blobber	staging
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging

[service-0chain]

Manual system tests [failure] with the following config

config	value
tests skipped	FALSE
system-tests	fix-update-miner-sharder-settings-tests
gosdk	NOT OVERRIDDEN
zboxcli	staging
zwalletcli	staging
0chain	staging
blobber	staging
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging

[service-0chain]

Manual system tests [success] with the following config

config	value
tests skipped	FALSE
system-tests	master
gosdk	NOT OVERRIDDEN
zboxcli	staging
zwalletcli	staging
0chain	staging
blobber	staging
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging