Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed curator functionality #2184

Merged
merged 7 commits into from
Mar 11, 2023
Merged

removed curator functionality #2184

merged 7 commits into from
Mar 11, 2023

Conversation

Hitenjain14
Copy link
Member

@Hitenjain14 Hitenjain14 commented Mar 1, 2023

Changes

Removed curator functionality from 0chain #2153 .

Need to be mentioned in CHANGELOG.md?

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@Hitenjain14
Copy link
Member Author

Will be updating related repos which are using curator_transfer_allocation to update the allocation owner .

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2023

Codecov Report

Merging #2184 (84d3bab) into staging (ca8f9c5) will decrease coverage by 0.09%.
The diff coverage is 56.25%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           staging    #2184      +/-   ##
===========================================
- Coverage    27.71%   27.63%   -0.09%     
===========================================
  Files          378      376       -2     
  Lines        62114    61872     -242     
===========================================
- Hits         17217    17097     -120     
+ Misses       42839    42743      -96     
+ Partials      2058     2032      -26     
Flag Coverage Δ
Unit-Tests 27.63% <56.25%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ode/go/0chain.net/smartcontract/dbs/event/enums.go 89.79% <ø> (-0.21%) ⬇️
...ode/go/0chain.net/smartcontract/dbs/event/event.go 0.00% <ø> (ø)
...e/go/0chain.net/smartcontract/dbs/event/eventdb.go 13.15% <ø> (+0.11%) ⬆️
...e/go/0chain.net/smartcontract/dbs/event/process.go 2.00% <ø> (+0.02%) ⬆️
...ain.net/smartcontract/storagesc/benchmark_setup.go 4.72% <0.00%> (+0.03%) ⬆️
...ain.net/smartcontract/storagesc/benchmark_tests.go 76.11% <ø> (-1.38%) ⬇️
...ain.net/smartcontract/storagesc/config_settigns.go 54.34% <ø> (-0.43%) ⬇️
...de/go/0chain.net/smartcontract/storagesc/models.go 53.20% <ø> (ø)
code/go/0chain.net/smartcontract/storagesc/sc.go 41.43% <ø> (+0.69%) ⬆️
...o/0chain.net/smartcontract/storagesc/allocation.go 51.30% <66.66%> (-0.17%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dabasov
Copy link
Member

dabasov commented Mar 7, 2023

remove files copletely

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests rm_curator
gosdk NOT OVERRIDDEN
zboxcli rm_curator
zwalletcli staging
0chain rm-curator
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests rm_curator
gosdk NOT OVERRIDDEN
zboxcli rm_curator
zwalletcli staging
0chain rm-curator
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@peterlimg peterlimg merged commit 00f064a into staging Mar 11, 2023
@peterlimg peterlimg deleted the rm-curator branch March 11, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove curator feature
5 participants