Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miner Package Import Fixes #222

Merged
merged 20 commits into from
May 2, 2021
Merged

Miner Package Import Fixes #222

merged 20 commits into from
May 2, 2021

Conversation

TheTeaParty
Copy link
Contributor

@TheTeaParty TheTeaParty commented May 1, 2021 •
edited

Closes #223

  • Renamed variables which are colliding with imported packages
  • Removed dot import path for logger

@TheTeaParty
Variables Conflicting with Import Path
ee2e1c5
@TheTeaParty
Remove Colliding Variable in PartialStateHandler
87c19a1
@TheTeaParty
Remove Colliding Variable in getNotarizedBlock
2fe81ab
@TheTeaParty
Remove Colliding Variable in PublishShareOrSigns
85031fe
@TheTeaParty
Remove Colliding Variable in protocol_view_change.go
c975e9b
@TheTeaParty
Remove Colliding Variable in worker.go
0aa98f1
@TheTeaParty
Removed dot import logger from miner main.go
cfb385b
@TheTeaParty
Removed dot import logger from miner worker.go
2536ba3
@TheTeaParty
Removed dot import logger from miner chain.go
0a5b1d4
@TheTeaParty
Removed dot import logger from miner m_handler.go
671d11f
@TheTeaParty
Removed dot import logger from miner protocol_block.go
de3f785
@TheTeaParty
Removed dot import logger from miner protocol_block
0ee7ee2
@TheTeaParty
Removed dot import logger from miner protocol_receive
a517c20
@TheTeaParty
Removed dot import logger from miner protocol_round
60d8bd0
@TheTeaParty
Removed dot import logger from miner protocol
d2ee6d9
@TheTeaParty
Removed dot import logger from miner round
70a1d78
@TheTeaParty
Removed dot import logger from miner worker.go
7dc0a26
@TheTeaParty TheTeaParty requested review from Sriep and platsko May 1, 2021 21:16
@TheTeaParty TheTeaParty mentioned this pull request May 1, 2021
Merged
Sriep
Sriep reviewed May 2, 2021
View reviewed changes
Copy link
Contributor

@Sriep Sriep left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks fine.
Commented out code is better removed than left to provide a maintenance overhead.
Unclear about the go.mod and go.sum changes.

code/go/0chain.net/miner/protocol_block.go Outdated Show resolved Hide resolved
code/go/0chain.net/miner/protocol_round.go Outdated Show resolved Hide resolved
code/go/0chain.net/miner/protocol_round.go Outdated Show resolved Hide resolved
code/go/0chain.net/miner/protocol_round.go Outdated Show resolved Hide resolved
code/go/0chain.net/go.mod Show resolved Hide resolved
code/go/0chain.net/go.sum Outdated Show resolved Hide resolved
@TheTeaParty TheTeaParty merged commit a71770b into master May 2, 2021
@platsko platsko deleted the feat/miner-import-fixes branch May 5, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sriep Sriep Sriep left review comments

@platsko platsko Awaiting requested review from platsko

@peterlimg peterlimg Awaiting requested review from peterlimg

@Kenwes13 Kenwes13 Awaiting requested review from Kenwes13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Miner variables are colliding with imported packages
2 participants
@TheTeaParty @Sriep